svn commit: r1156980 - in /camel/branches/camel-2.8.x/camel-core/src: main/java/org/apache/camel/spi/ExecutorServiceStrategy.java test/java/org/apache/camel/processor/aggregator/AggregateUnknownExecutorServiceRefTest.java

[da...@apache.org]

Author: davsclaus
Date: Fri Aug 12 06:41:55 2011
New Revision: 1156980

URL: http://svn.apache.org/viewvc?rev=1156980&view=rev
Log:
CAMEL-4328: Added unit test

Added:
    camel/branches/camel-2.8.x/camel-core/src/test/java/org/apache/camel/processor/aggregator/AggregateUnknownExecutorServiceRefTest.java
Modified:
    camel/branches/camel-2.8.x/camel-core/src/main/java/org/apache/camel/spi/ExecutorServiceStrategy.java

Modified: camel/branches/camel-2.8.x/camel-core/src/main/java/org/apache/camel/spi/ExecutorServiceStrategy.java
URL: http://svn.apache.org/viewvc/camel/branches/camel-2.8.x/camel-core/src/main/java/org/apache/camel/spi/ExecutorServiceStrategy.java?rev=1156980&r1=1156979&r2=1156980&view=diff
==============================================================================
--- camel/branches/camel-2.8.x/camel-core/src/main/java/org/apache/camel/spi/ExecutorServiceStrategy.java (original)
+++ camel/branches/camel-2.8.x/camel-core/src/main/java/org/apache/camel/spi/ExecutorServiceStrategy.java Fri Aug 12 06:41:55 2011
@@ -155,8 +155,6 @@ public interface ExecutorServiceStrategy
 
     /**
      * Creates a new scheduled thread pool.
-     * <p/>
-     * Will use the pool size from the default thread pool profile
      *
      * @param source      the source object, usually it should be <tt>this</tt> passed in as parameter
      * @param name        name which is appended to the thread name
@@ -167,6 +165,8 @@ public interface ExecutorServiceStrategy
 
     /**
      * Creates a new scheduled thread pool.
+     * <p/>
+     * Will use the pool size from the default thread pool profile
      *
      * @param source      the source object, usually it should be <tt>this</tt> passed in as parameter
      * @param name        name which is appended to the thread name

Added: camel/branches/camel-2.8.x/camel-core/src/test/java/org/apache/camel/processor/aggregator/AggregateUnknownExecutorServiceRefTest.java
URL: http://svn.apache.org/viewvc/camel/branches/camel-2.8.x/camel-core/src/test/java/org/apache/camel/processor/aggregator/AggregateUnknownExecutorServiceRefTest.java?rev=1156980&view=auto
==============================================================================
--- camel/branches/camel-2.8.x/camel-core/src/test/java/org/apache/camel/processor/aggregator/AggregateUnknownExecutorServiceRefTest.java (added)
+++ camel/branches/camel-2.8.x/camel-core/src/test/java/org/apache/camel/processor/aggregator/AggregateUnknownExecutorServiceRefTest.java Fri Aug 12 06:41:55 2011
@@ -0,0 +1,55 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.processor.aggregator;
+
+import org.apache.camel.ContextTestSupport;
+import org.apache.camel.FailedToCreateRouteException;
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.processor.BodyInAggregatingStrategy;
+
+/**
+ *
+ */
+public class AggregateUnknownExecutorServiceRefTest extends ContextTestSupport {
+
+    @Override
+    public boolean isUseRouteBuilder() {
+        return false;
+    }
+
+    public void testAggregateUnknownExecutorServiceRef() throws Exception {
+        try {
+            context.addRoutes(new RouteBuilder() {
+                @Override
+                public void configure() throws Exception {
+                    from("direct:start")
+                        .aggregate(header("id"), new BodyInAggregatingStrategy())
+                            // use an unknown executor service ref should fail
+                            .completionSize(3).executorServiceRef("myUnknownProfile")
+                            .to("log:foo")
+                            .to("mock:aggregated");
+                }
+            });
+            context.start();
+            fail("Should have thrown exception");
+        } catch (FailedToCreateRouteException e) {
+            IllegalArgumentException cause = assertIsInstanceOf(IllegalArgumentException.class, e.getCause());
+            assertEquals("ExecutorServiceRef myUnknownProfile not found in registry.", cause.getMessage());
+        }
+    }
+
+}
\ No newline at end of file