You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/07/22 06:07:40 UTC
Review Request 36673: Removed pthread from Once and Gate.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36673/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Michael Park.
Bugs: MESOS-3119
https://issues.apache.org/jira/browse/MESOS-3119
Repository: mesos
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/include/process/once.hpp 7d0d9309a41a8cc7c074b7566b7b9c411fa8ad45
3rdparty/libprocess/src/gate.hpp 7f6b3d8ddc823f637afcf6dc81b8371e4a794a0b
Diff: https://reviews.apache.org/r/36673/diff/
Testing
-------
make check in libprocess.
Thanks,
Joris Van Remoortere
Re: Review Request 36673: Removed pthread from Once and Gate.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 22, 2015, 4:35 a.m., Artem Harutyunyan wrote:
> > 3rdparty/libprocess/src/gate.hpp, line 18
> > <https://reviews.apache.org/r/36673/diff/1/?file=1018363#file1018363line18>
> >
> > Is this todo still valid?
>
> Joris Van Remoortere wrote:
> Sort of. Although it is true that std::mutex is implemented using futex, you could in theory directly implement on them?
> Ben, what do you think?
We can kill this TODO. ;-) I think it's from 2008 (pre Mesos).
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36673/#review92538
-----------------------------------------------------------
On July 22, 2015, 4:07 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36673/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 4:07 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Michael Park.
>
>
> Bugs: MESOS-3119
> https://issues.apache.org/jira/browse/MESOS-3119
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/once.hpp 7d0d9309a41a8cc7c074b7566b7b9c411fa8ad45
> 3rdparty/libprocess/src/gate.hpp 7f6b3d8ddc823f637afcf6dc81b8371e4a794a0b
>
> Diff: https://reviews.apache.org/r/36673/diff/
>
>
> Testing
> -------
>
> make check in libprocess.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 36673: Removed pthread from Once and Gate.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On July 22, 2015, 4:35 a.m., Artem Harutyunyan wrote:
> > 3rdparty/libprocess/src/gate.hpp, line 18
> > <https://reviews.apache.org/r/36673/diff/1/?file=1018363#file1018363line18>
> >
> > Is this todo still valid?
Sort of. Although it is true that std::mutex is implemented using futex, you could in theory directly implement on them?
Ben, what do you think?
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36673/#review92538
-----------------------------------------------------------
On July 22, 2015, 4:07 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36673/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 4:07 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Michael Park.
>
>
> Bugs: MESOS-3119
> https://issues.apache.org/jira/browse/MESOS-3119
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/once.hpp 7d0d9309a41a8cc7c074b7566b7b9c411fa8ad45
> 3rdparty/libprocess/src/gate.hpp 7f6b3d8ddc823f637afcf6dc81b8371e4a794a0b
>
> Diff: https://reviews.apache.org/r/36673/diff/
>
>
> Testing
> -------
>
> make check in libprocess.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 36673: Removed pthread from Once and Gate.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36673/#review92538
-----------------------------------------------------------
3rdparty/libprocess/src/gate.hpp (line 18)
<https://reviews.apache.org/r/36673/#comment146747>
Is this todo still valid?
- Artem Harutyunyan
On July 21, 2015, 9:07 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36673/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 9:07 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Michael Park.
>
>
> Bugs: MESOS-3119
> https://issues.apache.org/jira/browse/MESOS-3119
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/once.hpp 7d0d9309a41a8cc7c074b7566b7b9c411fa8ad45
> 3rdparty/libprocess/src/gate.hpp 7f6b3d8ddc823f637afcf6dc81b8371e4a794a0b
>
> Diff: https://reviews.apache.org/r/36673/diff/
>
>
> Testing
> -------
>
> make check in libprocess.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 36673: Removed pthread from Once and Gate.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36673/#review92553
-----------------------------------------------------------
Ship it!
Ship It!
- Artem Harutyunyan
On July 21, 2015, 10:55 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36673/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 10:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Michael Park.
>
>
> Bugs: MESOS-3119
> https://issues.apache.org/jira/browse/MESOS-3119
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/once.hpp 7d0d9309a41a8cc7c074b7566b7b9c411fa8ad45
> 3rdparty/libprocess/src/gate.hpp 7f6b3d8ddc823f637afcf6dc81b8371e4a794a0b
>
> Diff: https://reviews.apache.org/r/36673/diff/
>
>
> Testing
> -------
>
> make check in libprocess.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 36673: Removed pthread from Once and Gate.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36673/#review92802
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On July 21, 2015, 10:55 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36673/
> -----------------------------------------------------------
>
> (Updated July 21, 2015, 10:55 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Michael Park.
>
>
> Bugs: MESOS-3119
> https://issues.apache.org/jira/browse/MESOS-3119
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/once.hpp 7d0d9309a41a8cc7c074b7566b7b9c411fa8ad45
> 3rdparty/libprocess/src/gate.hpp 7f6b3d8ddc823f637afcf6dc81b8371e4a794a0b
>
> Diff: https://reviews.apache.org/r/36673/diff/
>
>
> Testing
> -------
>
> make check in libprocess.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 36673: Removed pthread from Once and Gate.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36673/
-----------------------------------------------------------
(Updated July 22, 2015, 5:55 a.m.)
Review request for mesos, Benjamin Hindman and Michael Park.
Changes
-------
addressed issues.
Bugs: MESOS-3119
https://issues.apache.org/jira/browse/MESOS-3119
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/once.hpp 7d0d9309a41a8cc7c074b7566b7b9c411fa8ad45
3rdparty/libprocess/src/gate.hpp 7f6b3d8ddc823f637afcf6dc81b8371e4a794a0b
Diff: https://reviews.apache.org/r/36673/diff/
Testing
-------
make check in libprocess.
Thanks,
Joris Van Remoortere
Re: Review Request 36673: Removed pthread from Once and Gate.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36673/#review92539
-----------------------------------------------------------
Ship it!
But see comments on https://reviews.apache.org/r/36629 regarding parameters of `synchronized_wait`.
- Benjamin Hindman
On July 22, 2015, 4:07 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36673/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 4:07 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Michael Park.
>
>
> Bugs: MESOS-3119
> https://issues.apache.org/jira/browse/MESOS-3119
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/once.hpp 7d0d9309a41a8cc7c074b7566b7b9c411fa8ad45
> 3rdparty/libprocess/src/gate.hpp 7f6b3d8ddc823f637afcf6dc81b8371e4a794a0b
>
> Diff: https://reviews.apache.org/r/36673/diff/
>
>
> Testing
> -------
>
> make check in libprocess.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>