[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #2765: Avoid duplicating code in BaseModel & FastCamelContext

[GitBox <gi...@apache.org>]

jamesnetherton opened a new pull request #2765:
URL: https://github.com/apache/camel-quarkus/pull/2765


   I stripped out most of the content from `FastCamelContext` except for CQ specific things.
   
   I wasn't sure about methods like `getComponentParameterJsonSchema` so I left them as-is. Our impl is mostly the same as the one in `DefaultCamelContext`, except that it does a registry lookup, which I'm assuming is some kind of optimisation?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton merged pull request #2765: Avoid duplicating code in BaseModel & FastCamelContext

[GitBox <gi...@apache.org>]

jamesnetherton merged pull request #2765:
URL: https://github.com/apache/camel-quarkus/pull/2765


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] zbendhiba commented on pull request #2765: Avoid duplicating code in BaseModel & FastCamelContext

[GitBox <gi...@apache.org>]

zbendhiba commented on pull request #2765:
URL: https://github.com/apache/camel-quarkus/pull/2765#issuecomment-859511654


   @jamesnetherton thanks for this PR ! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org