[GitHub] [airflow] wc-s commented on a change in pull request #18481: 18400 chart custom pod annotations

[GitBox <gi...@apache.org>]

wc-s commented on a change in pull request #18481:
URL: https://github.com/apache/airflow/pull/18481#discussion_r715215273



##########
File path: chart/templates/scheduler/scheduler-deployment.yaml
##########
@@ -85,6 +85,9 @@ spec:
         {{- if .Values.airflowPodAnnotations }}
         {{- toYaml .Values.airflowPodAnnotations | nindent 8 }}
         {{- end }}
+        {{- if .Values.scheduler.podAnnotations }}

Review comment:
       While I prefer `podAnnotations`, I absolutely do not mind one way or another, and can change them all if you'd like.
   
   The reason I prefer `podAnnotations` are:
   - I'd like to stick with helm's default chart's conventions (the example chart you'd get by doing `helm create test-chart`, and in their chart they have:
   ```
     template:
       metadata:
         {{- with .Values.podAnnotations }}
         annotations:
           {{- toYaml . | nindent 8 }}
         {{- end }}
   ```
   - I think the reason helm's default chart went with podAnnotations, is to make it clear it is not eg. the annotation of the `Deployment` object, an approach with which I agree




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org