You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "kirklund (GitHub)" <gi...@apache.org> on 2019/09/20 17:53:44 UTC

[GitHub] [geode] kirklund commented on pull request #4075: GEODE-6964: Move geode log4j core classes to geode-log4j

LogService uses ListCollectingServiceLoader to load the Provider impl for LogService. This means that LogService isn't ready when ListCollectingServiceLoader is used. If I leave it as LogService then it goes into recursion.

Basically, there are some classes that are used to initialize logging (such as ListCollectingServiceLoader) which need to either not log themselves or they have to use non-Geode logging. 

Classes such as ListCollectingServiceLoader should maybe move to geode-common and then that module must never have a dependency on geode-core or geode-logging. We might want to discuss that further...

[ Full content available at: https://github.com/apache/geode/pull/4075 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org