You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2026/07/20 04:00:11 UTC
[PR] build: move GTest and Google Benchmark setup into IcebergThirdpartyToolchain [iceberg-cpp]
LuciferYang opened a new pull request, #836:
URL: https://github.com/apache/iceberg-cpp/pull/836
## What
Fixes #829. The GoogleTest and Google Benchmark FetchContent setup lived in `src/iceberg/test/CMakeLists.txt` and `src/iceberg/benchmark/CMakeLists.txt`, apart from the other third-party dependencies. This follows the review discussion on #825, which suggested keeping dependency resolution in one place.
## How
- Add `resolve_gtest_dependency()` and `resolve_benchmark_dependency()` to `cmake_modules/IcebergThirdpartyToolchain.cmake`, next to the existing `resolve_*` functions.
- Gate them on `ICEBERG_BUILD_TESTS` and `ICEBERG_BUILD_BENCHMARKS`, the same conditions that already guard the test and benchmark subdirectories.
- Both functions call `prepare_fetchcontent()` like the other resolvers, so a command-line `-DCMAKE_COMPILE_WARNING_AS_ERROR=ON` does not build the vendored GTest/Benchmark sources with `-Werror`.
- Version pins are unchanged. Only CMake is affected; Meson resolves these through `subprojects/*.wrap`, so it needs no change.
## Verified
- `-DICEBERG_BUILD_BENCHMARKS=ON`: both dependencies fetch; `benchmark_smoke` and `schema_test` build; `ctest -R schema_test` passes.
- Tests and benchmarks both off: neither dependency is fetched.
- `-DCMAKE_COMPILE_WARNING_AS_ERROR=ON` with benchmarks on: configure and build succeed.
- `pre-commit run -a` clean.
---
This contribution was authored with assistance from Claude Opus 4.8, in line with the Iceberg guidelines for AI-assisted contributions (https://iceberg.apache.org/contribute/#guidelines-for-ai-assisted-contributions). All changes were reviewed and tested by the author.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] build: move GTest and Google Benchmark setup into IcebergThirdpartyToolchain [iceberg-cpp]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac merged PR #836:
URL: https://github.com/apache/iceberg-cpp/pull/836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] build: move GTest and Google Benchmark setup into IcebergThirdpartyToolchain [iceberg-cpp]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #836:
URL: https://github.com/apache/iceberg-cpp/pull/836#issuecomment-5019810749
Thank you @wgtmac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org