You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/13 04:37:56 UTC

[GitHub] [superset] jinghua-qa opened a new issue #14599: [setting] edges were cutting on settings menu

jinghua-qa opened a new issue #14599:
URL: https://github.com/apache/superset/issues/14599


   ## Screenshot
   
   <img width="1773" alt="Screen Shot 2021-05-12 at 9 33 49 PM" src="https://user-images.githubusercontent.com/81597121/118078008-1e3ab000-b36a-11eb-955b-94fcd3c89956.png">
   
   ## Description
   
   Right edge and bottom of the settings menu are cut
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] michael-s-molina commented on issue #14599: [setting] edges were cutting on settings menu

Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #14599:
URL: https://github.com/apache/superset/issues/14599#issuecomment-842261691


   @junlincc @geido https://github.com/apache/superset/pull/14557 fixed the `About` padding.  We can close this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc edited a comment on issue #14599: [setting] edges were cutting on settings menu

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #14599:
URL: https://github.com/apache/superset/issues/14599#issuecomment-840313016


   Right edge is looking ok on master, the bottom does need some paddddddding. 🤦🏾‍♀️
   <img width="557" alt="Screen Shot 2021-05-12 at 10 32 17 PM" src="https://user-images.githubusercontent.com/67837651/118082373-edf70f80-b371-11eb-9f68-0de6d32ee227.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] jinghua-qa closed issue #14599: [setting] edges were cutting on settings menu

Posted by GitBox <gi...@apache.org>.
jinghua-qa closed issue #14599:
URL: https://github.com/apache/superset/issues/14599


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #14599: [setting] edges were cutting on settings menu

Posted by GitBox <gi...@apache.org>.
geido commented on issue #14599:
URL: https://github.com/apache/superset/issues/14599#issuecomment-842243352


   @junlincc 
   
   The menu looks fine on master
   
   ![Screen Shot 2021-05-17 at 14 21 10 (2)](https://user-images.githubusercontent.com/60598000/118480660-38361300-b71b-11eb-96c5-d81d1e52eb34.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #14599: [setting] edges were cutting on settings menu

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #14599:
URL: https://github.com/apache/superset/issues/14599#issuecomment-840313016


   Right edge is looking ok on master, the bottom does need some paddddddding. 🤦🏾‍♀️


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] jinghua-qa commented on issue #14599: [setting] edges were cutting on settings menu

Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on issue #14599:
URL: https://github.com/apache/superset/issues/14599#issuecomment-864212851


   Verified fixed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #14599: [setting] edges were cutting on settings menu

Posted by GitBox <gi...@apache.org>.
geido commented on issue #14599:
URL: https://github.com/apache/superset/issues/14599#issuecomment-841809002






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] michael-s-molina commented on issue #14599: [setting] edges were cutting on settings menu

Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #14599:
URL: https://github.com/apache/superset/issues/14599#issuecomment-842261691


   @junlincc @geido https://github.com/apache/superset/pull/14557 fixed the `About` padding.  We can close this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #14599: [setting] edges were cutting on settings menu

Posted by GitBox <gi...@apache.org>.
geido commented on issue #14599:
URL: https://github.com/apache/superset/issues/14599#issuecomment-841809002


   Having a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org