You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cfmcgrady (via GitHub)" <gi...@apache.org> on 2024/10/23 06:58:42 UTC

[PR] [CELEBORN-1666] Bump scala-protoc from 1.0.6 to 1.0.7 [celeborn]

cfmcgrady opened a new pull request, #2842:
URL: https://github.com/apache/celeborn/pull/2842

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   As title
   
   ### Why are the changes needed?
   
   As title
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   
   Pass CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1666] Bump scala-protoc from 1.0.6 to 1.0.7 [celeborn]

Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady closed pull request #2842: [CELEBORN-1666] Bump scala-protoc from 1.0.6 to 1.0.7
URL: https://github.com/apache/celeborn/pull/2842


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1666] Bump scala-protoc from 1.0.6 to 1.0.7 [celeborn]

Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #2842:
URL: https://github.com/apache/celeborn/pull/2842#issuecomment-2434158016

   thanks, merging to main(v0.6.0)/branch-0.5(v0.5.3)/branch-0.4(v0.4.3).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1666] Bump scala-protoc from 1.0.6 to 1.0.7 [celeborn]

Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on code in PR #2842:
URL: https://github.com/apache/celeborn/pull/2842#discussion_r1812426007


##########
project/CelebornBuild.scala:
##########
@@ -347,7 +347,7 @@ object CelebornCommonSettings {
     PB.protocVersion := Dependencies.protocVersion,
     // set proto sources path
     Compile / PB.protoSources := Seq(sourceDirectory.value / "main" / "proto"),
-    Compile / PB.targets := Seq(PB.gens.java -> (Compile / sourceManaged).value)
+    Compile / PB.targets := Seq(PB.gens.java(Dependencies.protocVersion) -> (Compile / sourceManaged).value)

Review Comment:
   The `protobuf-java` version is required. see https://github.com/thesamet/sbt-protoc/issues/360



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org