You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/30 11:15:49 UTC
[GitHub] [spark] beliefer opened a new pull request, #37033: [SPARK-39453][SQL][FOLLOWUP] Let Rand in filter is more meaningful.
beliefer opened a new pull request, #37033:
URL: https://github.com/apache/spark/pull/37033
### What changes were proposed in this pull request?
https://github.com/apache/spark/pull/36830 makes DS V2 supports push down misc non-aggregate functions(non ANSI).
But he `Rand` in test case looks no meaningful.
### Why are the changes needed?
Let `Rand` in filter is more meaningful.
### Does this PR introduce _any_ user-facing change?
'No'.
Just update test case.
### How was this patch tested?
Just update test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #37033: [SPARK-39453][SQL][TESTS][FOLLOWUP] Let `RAND` in filter is more meaningful.
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #37033:
URL: https://github.com/apache/spark/pull/37033#issuecomment-1174645332
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a diff in pull request #37033: [SPARK-39453][SQL][FOLLOWUP] Let Rand in filter is more meaningful.
Posted by GitBox <gi...@apache.org>.
beliefer commented on code in PR #37033:
URL: https://github.com/apache/spark/pull/37033#discussion_r910902803
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -856,11 +856,11 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with ExplainSuiteHel
val df11 = sql(
"""
|SELECT * FROM h2.test.employee
- |WHERE GREATEST(bonus, 1100) > 1200 AND LEAST(salary, 10000) > 9000 AND RAND(1) < 1
Review Comment:
We already test LEAST at https://github.com/apache/spark/blob/c11fc3005d5407ca44c848de7d074d2a10f743a4/sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala#L869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #37033: [SPARK-39453][SQL][TESTS][FOLLOWUP] Let `RAND` in filter is more meaningful.
Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #37033:
URL: https://github.com/apache/spark/pull/37033#issuecomment-1174646093
@cloud-fan Thank you !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #37033: [SPARK-39453][SQL][TESTS][FOLLOWUP] Let `RAND` in filter is more meaningful.
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #37033: [SPARK-39453][SQL][TESTS][FOLLOWUP] Let `RAND` in filter is more meaningful.
URL: https://github.com/apache/spark/pull/37033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #37033: [SPARK-39453][SQL][TESTS][FOLLOWUP] Let `RAND` in filter is more meaningful.
Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #37033:
URL: https://github.com/apache/spark/pull/37033#issuecomment-1174629748
ping @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #37033: [SPARK-39453][SQL][FOLLOWUP] Let Rand in filter is more meaningful.
Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #37033:
URL: https://github.com/apache/spark/pull/37033#issuecomment-1171092527
ping @huaxingao cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org