You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "dsmiley (via GitHub)" <gi...@apache.org> on 2024/09/09 14:22:43 UTC
[PR] SOLR-17414: Multi-threaded search: don't throw RejectedExecutionException [solr]
dsmiley opened a new pull request, #2701:
URL: https://github.com/apache/solr/pull/2701
Instead, use a caller-runs policy.
https://issues.apache.org/jira/browse/SOLR-17414
This Executor is a bit special, and as such I don't think we should modify ExecutorUtil for the needs of one executor. I'd like to back out Christine's and Gus's change. Instead, MDCAwareThreadPoolExecutor can be subclasses wherever. Didn't do this yet.
If we imagine this Executor is of general use, then its initialization should remain in CoreContainer. I put it in SolrIndexSearcher but could move it. IMO it is of general use; the multi-threaded faceting should use the same. So I'm inclined to move back.
The queue size check should be configurable. I could see values like 1, or the same as the thread count.
It'd be nice to block but without busy waiting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17414: Multi-threaded search: don't throw RejectedExecutionException [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #2701:
URL: https://github.com/apache/solr/pull/2701#issuecomment-2379925519
Barring benchmarks & CHANGES.txt, I think this is ready to merge.
I changed to using a blocking strategy instead of caller-runs. It should be easier to manage a Solr node's CPU consumption; more queries aren't going to tip it over (within reason). But to maximize a machine's resources, it may be necessary to configure a multiple of the number of available CPUs; we'll see I guess.
I could see follow-on work to ensure there's prioritization of an earlier request's submissions over that of another concurrently happening slightly after. But I suppose it doesn't *really* matter. Also, maybe the search *itself* (i.e. thread processing SearchHandler) should use this executor? Although it's not necessarily CPU-bound (does distributed-search) whereas segment-search is. But we could do the distrib=false requests here. Hmm. An experiment for another day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17414: Multi-threaded search: don't throw RejectedExecutionException [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley merged PR #2701:
URL: https://github.com/apache/solr/pull/2701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org