You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by mateiz <gi...@git.apache.org> on 2014/03/17 07:56:58 UTC

[GitHub] spark pull request: SPARK-1102: Create a saveAsNewAPIHadoopDataset...

Github user mateiz commented on the pull request:

    https://github.com/apache/spark/pull/12#issuecomment-37789066
  
    Hey, sorry for the super late reply. This looks good but it would be good to add a test for `saveAsNewAPIHadoopDataset` directly (passing it the file output format and such through a Conf). Once you do that I think this is ready to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---