You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/01/21 07:00:49 UTC
[GitHub] [phoenix] stoty opened a new pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
stoty opened a new pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103
…doop 3.1.4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty edited a comment on pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
stoty edited a comment on pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#issuecomment-764430071
Note that unless I managed to mess up the Jenkinsfile syntax, the Yetus results are irrelevant, as none of this applies the the HBase 2.4 profile.
Also note that this includes the fix for PHOENIX-6332
Edit: The Jenkisfile isn't touched by Yetus, either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#issuecomment-764476143
> It turns out that even HBase minor versions break ABI compatibility, so there's a fair chance that 3.2.1 will that as well.
> ATM it seems that the best solution is to stick with the Hadoopminor version that the HBase branch defaults to.
>
> Otherwise the build process would get even more convoluted and error-prone.
Agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#issuecomment-764639053
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 15m 15s | master passed |
| +0 | hbaserecompile | 22m 30s | HBase recompiled. |
| +1 :green_heart: | compile | 2m 2s | master passed |
| +1 :green_heart: | javadoc | 1m 37s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 11m 40s | the patch passed |
| +0 | hbaserecompile | 21m 52s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 54s | the patch passed |
| +1 :green_heart: | javac | 1m 54s | the patch passed |
| +1 :green_heart: | markdownlint | 0m 2s | The patch generated 0 new + 29 unchanged - 1 fixed = 29 total (was 30) |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | shelldocs | 0m 4s | There were no new shelldocs issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 1m 29s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 122m 34s | root in the patch failed. |
| -1 :x: | asflicense | 1m 4s | The patch generated 610 ASF License warnings. |
| | | 177m 0s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1103/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1103 |
| Optional Tests | dupname asflicense markdownlint shellcheck shelldocs javac javadoc unit xml compile |
| uname | Linux d80d43d26c0c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / e74857b |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1103/2/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1103/2/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1103/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 11245 (vs. ulimit of 30000) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1103/2/console |
| versions | git=2.7.4 maven=3.3.9 shellcheck=0.7.0 markdownlint=0.22.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on a change in pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#discussion_r561745498
##########
File path: pom.xml
##########
@@ -1577,6 +1581,7 @@
<hbase.version>${hbase-2.3.runtime.version}</hbase.version>
<hbase.thirdparty.version>3.3.0</hbase.thirdparty.version>
<zookeeper.version>3.5.7</zookeeper.version>
+ <hadoop.version>3.1.3</hadoop.version>
Review comment:
> I do not have a firm opinon either way, if you think that we should simnply revert PHOENIX-6326, that is also possible.
I also don't have firm opinion either. I think this might take a while doing testing and all, maybe bake in multibranch build for few days and once we see things clear, maybe we should proceed. Given all the work you have done, i think good to proceed with updated Hadoop versions. Only if it turns out to significant tests failing due to Hadoop upgrade, maybe we can revert and take some time with individual HBase profiles. If we go in this situation, please let me know, i will try to test specific HBase profile and try to help ensure the least latest Hadoop version that we can support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on a change in pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#discussion_r561696831
##########
File path: pom.xml
##########
@@ -1545,6 +1547,7 @@
<hbase.profile>2.1</hbase.profile>
<hbase.compat.version>2.1.6</hbase.compat.version>
<hbase.version>${hbase-2.1.runtime.version}</hbase.version>
+ <hadoop.version>3.0.3</hadoop.version>
Review comment:
While confirming `hadoop-three.version` on branch-2.1, when I saw default value of `${hbase-2.1.runtime.version}` as `2.1.10` I was surprised to see only 2.1.10 RC tags available on HBase but release tag `rel/2.1.10` is missing!
##########
File path: pom.xml
##########
@@ -1560,6 +1563,7 @@
<hbase.profile>2.2</hbase.profile>
<hbase.compat.version>2.2.5</hbase.compat.version>
<hbase.version>${hbase-2.2.runtime.version}</hbase.version>
+ <hadoop.version>3.1.3</hadoop.version>
Review comment:
This could be 3.1.2 as latest HBase release 2.2.6 supports it: https://github.com/apache/hbase/blob/rel/2.2.6/pom.xml#L1373
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#issuecomment-764430071
Note that unless I managed to mess up the Jenkinsfile syntax, the Yetus results are irrelevant, as none of this applies the the HBase 2.4 profile.
Also note that this includes the fix for PHOENIX-6332
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#issuecomment-764444389
Sure. I am not aware of Jenkinsfile change and it's purpose, but rest looks good, pending QA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#issuecomment-764442214
Let's get this fixed first, then we can try out 3.2.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#issuecomment-764430071
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on a change in pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#discussion_r561696831
##########
File path: pom.xml
##########
@@ -1545,6 +1547,7 @@
<hbase.profile>2.1</hbase.profile>
<hbase.compat.version>2.1.6</hbase.compat.version>
<hbase.version>${hbase-2.1.runtime.version}</hbase.version>
+ <hadoop.version>3.0.3</hadoop.version>
Review comment:
While confirming `hadoop-three.version` on branch-2.1, when I saw default value of `${hbase-2.1.runtime.version}` as `2.1.10` I was surprised to see only 2.1.10 RC tags available on HBase but release tag `rel/2.1.10` is missing!
##########
File path: pom.xml
##########
@@ -1560,6 +1563,7 @@
<hbase.profile>2.2</hbase.profile>
<hbase.compat.version>2.2.5</hbase.compat.version>
<hbase.version>${hbase-2.2.runtime.version}</hbase.version>
+ <hadoop.version>3.1.3</hadoop.version>
Review comment:
This could be 3.1.2 as latest HBase release 2.2.6 supports it: https://github.com/apache/hbase/blob/rel/2.2.6/pom.xml#L1373
##########
File path: pom.xml
##########
@@ -1577,6 +1581,7 @@
<hbase.version>${hbase-2.3.runtime.version}</hbase.version>
<hbase.thirdparty.version>3.3.0</hbase.thirdparty.version>
<zookeeper.version>3.5.7</zookeeper.version>
+ <hadoop.version>3.1.3</hadoop.version>
Review comment:
Same here https://github.com/apache/hbase/blob/rel/2.3.3/pom.xml#L1341
##########
File path: pom.xml
##########
@@ -1577,6 +1581,7 @@
<hbase.version>${hbase-2.3.runtime.version}</hbase.version>
<hbase.thirdparty.version>3.3.0</hbase.thirdparty.version>
<zookeeper.version>3.5.7</zookeeper.version>
+ <hadoop.version>3.1.3</hadoop.version>
Review comment:
I see, I thought we want to keep the same default Hadoop version for HBase profiles as the default Hadoop version kept by the respective HBase versions.
> This only affects the defaults, and the binary distributions, end users are free to build with wathever version they choose.
That's right, end users are free to build with versions of their choice.
> I am running a set of builds with HBase 2.1/2.2/2.3 and Hadoop 3.0.3/3.1.3/3.1.3 respectively, so we'll know more in about an hour.
Great!
##########
File path: pom.xml
##########
@@ -1577,6 +1581,7 @@
<hbase.version>${hbase-2.3.runtime.version}</hbase.version>
<hbase.thirdparty.version>3.3.0</hbase.thirdparty.version>
<zookeeper.version>3.5.7</zookeeper.version>
+ <hadoop.version>3.1.3</hadoop.version>
Review comment:
> I do not have a firm opinon either way, if you think that we should simnply revert PHOENIX-6326, that is also possible.
I also don't have firm opinion either. I think this might take a while doing testing and all, maybe bake in multibranch build for few days and once we see things clear, maybe we should proceed. Given all the work you have done, i think good to proceed with updated Hadoop versions. Only if it turns out to significant tests failing due to Hadoop upgrade, maybe we can revert and take some time with individual HBase profiles. If we go in this situation, please let me know, i will try to test specific HBase profile and try to help ensure the least latest Hadoop version that we can support.
##########
File path: pom.xml
##########
@@ -1577,6 +1581,7 @@
<hbase.version>${hbase-2.3.runtime.version}</hbase.version>
<hbase.thirdparty.version>3.3.0</hbase.thirdparty.version>
<zookeeper.version>3.5.7</zookeeper.version>
+ <hadoop.version>3.1.3</hadoop.version>
Review comment:
> I do not have a firm opinon either way, if you think that we should simnply revert PHOENIX-6326, that is also possible.
I also don't have firm opinion either. I think this might take a while doing testing and all, maybe bake in multibranch build for a couple of days and once we see things clear, maybe we should proceed. Given all the work you have done, i think good to proceed with updated Hadoop versions. Only if it turns out to be significant tests failing due to Hadoop upgrade, maybe we can revert and take some time with individual HBase profiles. If we go in this situation, please let me know, i will try to test specific HBase profile and try to help ensure the least latest Hadoop version that we can support.
On the other hand, builds you are running currently themselves should be sufficient to know the stability I believe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on a change in pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#discussion_r561734307
##########
File path: pom.xml
##########
@@ -1577,6 +1581,7 @@
<hbase.version>${hbase-2.3.runtime.version}</hbase.version>
<hbase.thirdparty.version>3.3.0</hbase.thirdparty.version>
<zookeeper.version>3.5.7</zookeeper.version>
+ <hadoop.version>3.1.3</hadoop.version>
Review comment:
I see, I thought we want to keep the same default Hadoop version for HBase profiles as the default Hadoop version kept by the respective HBase versions.
> This only affects the defaults, and the binary distributions, end users are free to build with wathever version they choose.
That's right, end users are free to build with versions of their choice.
> I am running a set of builds with HBase 2.1/2.2/2.3 and Hadoop 3.0.3/3.1.3/3.1.3 respectively, so we'll know more in about an hour.
Great!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on a change in pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#discussion_r561700592
##########
File path: pom.xml
##########
@@ -1577,6 +1581,7 @@
<hbase.version>${hbase-2.3.runtime.version}</hbase.version>
<hbase.thirdparty.version>3.3.0</hbase.thirdparty.version>
<zookeeper.version>3.5.7</zookeeper.version>
+ <hadoop.version>3.1.3</hadoop.version>
Review comment:
Same here https://github.com/apache/hbase/blob/rel/2.3.3/pom.xml#L1341
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on a change in pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#discussion_r561708911
##########
File path: pom.xml
##########
@@ -1577,6 +1581,7 @@
<hbase.version>${hbase-2.3.runtime.version}</hbase.version>
<hbase.thirdparty.version>3.3.0</hbase.thirdparty.version>
<zookeeper.version>3.5.7</zookeeper.version>
+ <hadoop.version>3.1.3</hadoop.version>
Review comment:
3.1.2 is not the latest version it supports, it's just the default. (Even HBase branch-2.4 and master uses Hadoop 3.1.2 as default)
There seems to be no problem with using Hadoop 3.1.3 with Hbase 2.2 and 2.3, nor with using 3.1.4 with 2.4.
On one hand, we get bug, security and performance fixes when using a later (compatible) version.
On the other hand, simply sticking to the Hbase default version also has merit, as we can avoid the kind of problems that the last upgrade has created.
This only affects the defaults, and the binary distributions, end users are free to build with wathever version they choose.
I am running a set of builds with HBase 2.1/2.2/2.3 and Hadoop 3.0.3/3.1.3/3.1.3 respectively, so we'll know more in about an hour.
I do not have a firm opinon either way, if you think that we should simnply revert PHOENIX-6326, that is also possible.
Provided that the tests with the above combinations are clean, would you prefer the 3.0.3/3.1.3/3.1.3/3.1.4 version or the old 3.0.3/3.1.2/3.1.2/3.1.2 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#issuecomment-764440173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#issuecomment-764440173
And HBase 2.4 profile can support Hadoop 3.2.1. Would you prefer to include it with this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#issuecomment-764534499
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 1s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 15m 22s | master passed |
| +0 | hbaserecompile | 22m 24s | HBase recompiled. |
| +1 :green_heart: | compile | 1m 32s | master passed |
| +1 :green_heart: | javadoc | 1m 20s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 32s | the patch passed |
| +0 | hbaserecompile | 17m 14s | HBase recompiled. |
| +1 :green_heart: | compile | 2m 0s | the patch passed |
| +1 :green_heart: | javac | 2m 0s | the patch passed |
| +1 :green_heart: | markdownlint | 0m 5s | The patch generated 0 new + 29 unchanged - 1 fixed = 29 total (was 30) |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | shelldocs | 0m 4s | There were no new shelldocs issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 1m 38s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 152m 23s | root in the patch failed. |
| -1 :x: | asflicense | 1m 12s | The patch generated 610 ASF License warnings. |
| | | 202m 11s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.rpc.UpdateCacheIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1103/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1103 |
| Optional Tests | dupname asflicense markdownlint shellcheck shelldocs javac javadoc unit xml compile |
| uname | Linux 0ae8acb7fd45 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / e74857b |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1103/1/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1103/1/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1103/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 10416 (vs. ulimit of 30000) |
| modules | C: . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1103/1/console |
| versions | git=2.7.4 maven=3.3.9 shellcheck=0.7.0 markdownlint=0.22.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#issuecomment-764479009
Actually, I should have written:
It turns out that even **Hadoop** minor versions break ABI compatibility,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani edited a comment on pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#issuecomment-764476143
> It turns out that even HBase minor versions break ABI compatibility, so there's a fair chance that 3.2.1 will that as well.
> ATM it seems that the best solution is to stick with the Hadoopminor version that the HBase branch defaults to.
>
> Otherwise the build process would get even more convoluted and error-prone.
Agree.
> ATM it seems that the best solution is to stick with the Hadoopminor version that the HBase branch defaults to.
I think here maybe we should stick with Hadoopminor version that the latest HBase release branch defaults to on respective minor releases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani edited a comment on pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#issuecomment-764476143
> It turns out that even HBase minor versions break ABI compatibility, so there's a fair chance that 3.2.1 will that as well.
> ATM it seems that the best solution is to stick with the Hadoopminor version that the HBase branch defaults to.
>
> Otherwise the build process would get even more convoluted and error-prone.
Agree.
> ATM it seems that the best solution is to stick with the Hadoopminor version that the HBase branch defaults to.
I think here maybe we should stick with Hadoopminor version that the latest HBase release branch defaults to on respective minor releases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty edited a comment on pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
stoty edited a comment on pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#issuecomment-764430071
Note that unless I managed to mess up the Jenkinsfile syntax, the Yetus results are irrelevant, as none of this applies the the HBase 2.4 profile.
Also note that this includes the fix for PHOENIX-6332
Edit: The Jenkisfile isn't touched by Yetus, either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on a change in pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#discussion_r561708911
##########
File path: pom.xml
##########
@@ -1577,6 +1581,7 @@
<hbase.version>${hbase-2.3.runtime.version}</hbase.version>
<hbase.thirdparty.version>3.3.0</hbase.thirdparty.version>
<zookeeper.version>3.5.7</zookeeper.version>
+ <hadoop.version>3.1.3</hadoop.version>
Review comment:
3.1.2 is not the latest version it supports, it's just the default. (Even HBase branch-2.4 and master uses Hadoop 3.1.2 as default)
There seems to be no problem with using Hadoop 3.1.3 with Hbase 2.2 and 2.3, nor with using 3.1.4 with 2.4.
On one hand, we get bug, security and performance fixes when using a later (compatible) version.
On the other hand, simply sticking to the Hbase default version also has merit, as we can avoid the kind of problems that the last upgrade has created.
This only affects the defaults, and the binary distributions, end users are free to build with wathever version they choose.
I am running a set of builds with HBase 2.1/2.2/2.3 and Hadoop 3.0.3/3.1.3/3.1.3 respectively, so we'll know more in about an hour.
I do not have a firm opinon either way, if you think that we should simnply revert PHOENIX-6326, that is also possible.
Provided that the tests with the above combinations are clean, would you prefer the 3.0.3/3.1.3/3.1.3/3.1.4 version or the old 3.0.3/3.1.2/3.1.2/3.1.2 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#issuecomment-764473126
It turns out that even HBase minor versions break ABI compatibility, so there's a fair chance that 3.2.1 will that as well.
ATM it seems that the best solution is to stick with the Hadoopminor version that the HBase branch defaults to.
Otherwise the build process would get even more convoluted and error-prone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on a change in pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103#discussion_r561745498
##########
File path: pom.xml
##########
@@ -1577,6 +1581,7 @@
<hbase.version>${hbase-2.3.runtime.version}</hbase.version>
<hbase.thirdparty.version>3.3.0</hbase.thirdparty.version>
<zookeeper.version>3.5.7</zookeeper.version>
+ <hadoop.version>3.1.3</hadoop.version>
Review comment:
> I do not have a firm opinon either way, if you think that we should simnply revert PHOENIX-6326, that is also possible.
I also don't have firm opinion either. I think this might take a while doing testing and all, maybe bake in multibranch build for a couple of days and once we see things clear, maybe we should proceed. Given all the work you have done, i think good to proceed with updated Hadoop versions. Only if it turns out to be significant tests failing due to Hadoop upgrade, maybe we can revert and take some time with individual HBase profiles. If we go in this situation, please let me know, i will try to test specific HBase profile and try to help ensure the least latest Hadoop version that we can support.
On the other hand, builds you are running currently themselves should be sufficient to know the stability I believe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #1103: PHOENIX-6333 Hbase versions older than 2.4.0 are incompatible with Ha…
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #1103:
URL: https://github.com/apache/phoenix/pull/1103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org