You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Scott Carey (JIRA)" <ji...@apache.org> on 2011/01/10 20:30:46 UTC
[jira] Commented: (AVRO-730) Implement set and remove methods from
List interface on GenericData.Array
[ https://issues.apache.org/jira/browse/AVRO-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979703#action_12979703 ]
Scott Carey commented on AVRO-730:
----------------------------------
Overall looks good.
Tests could be improved by adding checks that trigger IndexOutOfBoundsException when we call set() or remove() on a shrunken array. testArrayRemove() checks that for get() but not set() or remove().
Additionally, we should test that adding another element after removal works as expected.
> Implement set and remove methods from List interface on GenericData.Array
> -------------------------------------------------------------------------
>
> Key: AVRO-730
> URL: https://issues.apache.org/jira/browse/AVRO-730
> Project: Avro
> Issue Type: New Feature
> Components: java
> Affects Versions: 1.4.1
> Reporter: Chase Bradford
> Attachments: AVRO-730.patch
>
>
> GenericData.Array throws an UnsupportedOperationException when set() or remove() are used on an instance of it. I think it's reasonable for those methods to work though, since their implementation is simple and inline with most other List types.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.