(texera) branch main updated: refactor(amber): remove the unused SuccessExecutionResult DTO (#7836)

[gi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/texera.git


The following commit(s) were added to refs/heads/main by this push:
     new 425f5a5ad9 refactor(amber): remove the unused SuccessExecutionResult DTO (#7836)
425f5a5ad9 is described below

commit 425f5a5ad94ed600f6aa0ccdce29f366b17b586d
Author: Meng Wang <me...@uci.edu>
AuthorDate: Sat Aug 22 07:59:40 2026 +0000

    refactor(amber): remove the unused SuccessExecutionResult DTO (#7836)
    
    ### What changes were proposed in this PR?
    
    Deletes `SuccessExecutionResult` and its spec — 68 lines, no behaviour
    change. The class arrived unreferenced in the 2020 amber bulk import
    (`41a8a9201`) and mirrors the `{ code, resultID, result }` response
    envelope that #1214 removed from the frontend in 2021; nothing in
    `amber`, `frontend`, `agent-service`, or any resource/config references
    it, so its only consumer was its own coverage spec, which goes with it.
    Not to be confused with `SyncExecutionResult` in the same package, which
    is live.
    
    ### Any related issues, documentation, discussions?
    
    Closes #7829.
    
    ### How was this PR tested?
    
    `WorkflowExecutionService/Test/compile` passes after the deletion — the
    compiler confirms nothing referenced the class; a repo-wide text search
    finds no other occurrence.
    
    ### Was this PR authored or co-authored using generative AI tooling?
    
    Generated-by: Claude Code (claude-fable-5)
---
 .../web/resource/SuccessExecutionResult.scala      | 26 --------------
 .../web/resource/SuccessExecutionResultSpec.scala  | 42 ----------------------
 2 files changed, 68 deletions(-)

diff --git a/amber/src/main/scala/org/apache/texera/web/resource/SuccessExecutionResult.scala b/amber/src/main/scala/org/apache/texera/web/resource/SuccessExecutionResult.scala
deleted file mode 100644
index 2318d054ca..0000000000
--- a/amber/src/main/scala/org/apache/texera/web/resource/SuccessExecutionResult.scala
+++ /dev/null
@@ -1,26 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-package org.apache.texera.web.resource
-
-case class SuccessExecutionResult(
-    resultID: String,
-    code: Integer = 0,
-    result: List[String] = List()
-)
diff --git a/amber/src/test/scala/org/apache/texera/web/resource/SuccessExecutionResultSpec.scala b/amber/src/test/scala/org/apache/texera/web/resource/SuccessExecutionResultSpec.scala
deleted file mode 100644
index f013109e3c..0000000000
--- a/amber/src/test/scala/org/apache/texera/web/resource/SuccessExecutionResultSpec.scala
+++ /dev/null
@@ -1,42 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-package org.apache.texera.web.resource
-
-import org.scalatest.flatspec.AnyFlatSpec
-import org.scalatest.matchers.should.Matchers
-
-class SuccessExecutionResultSpec extends AnyFlatSpec with Matchers {
-
-  "SuccessExecutionResult" should "default code to 0 and result to an empty list" in {
-    // The defaults are the success-path values that JSON consumers (the
-    // frontend execution-result handler) treat as "ok with no payload".
-    // A change to either default would silently shift contract semantics.
-    val r = SuccessExecutionResult(resultID = "abc")
-    r.resultID shouldBe "abc"
-    r.code shouldBe 0
-    r.result shouldBe List.empty
-  }
-
-  it should "carry the passed code and result list when provided" in {
-    val r = SuccessExecutionResult(resultID = "xyz", code = 1, result = List("a", "b"))
-    r.code shouldBe 1
-    r.result shouldBe List("a", "b")
-  }
-}