[GitHub] [james-project] jeantil commented on a change in pull request #450: JAMES-3591 Warn against CassandraBlobStore usage

[GitBox <gi...@apache.org>]

jeantil commented on a change in pull request #450:
URL: https://github.com/apache/james-project/pull/450#discussion_r640092600



##########
File path: server/blob/blob-cassandra/src/main/java/org/apache/james/blob/cassandra/CassandraBlobStoreDAO.java
##########
@@ -80,6 +87,9 @@ public CassandraBlobStoreDAO(CassandraDefaultBucketDAO defaultBucketDAO,
 
         this.metricClOneMissCount = metricFactory.generate(CASSANDRA_BLOBSTORE_CL_ONE_MISS_COUNT_METRIC_NAME);
         this.metricClOneHitCount = metricFactory.generate(CASSANDRA_BLOBSTORE_CL_ONE_HIT_COUNT_METRIC_NAME);
+
+        LOGGER.warn("WARNING: JAMES-3591 Cassandra is not made to store large binary content, its use will be suboptimal compared to " +

Review comment:
       Only if this log can be disabled by a config flag. otherwise a log at warn will trigger potentially spurious alerting in various tools such as sentry and it's a pain to properly ignore.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org