You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/05/10 19:35:33 UTC

[GitHub] [ozone] prashantpogde commented on a diff in pull request #3397: [Multi-Tenant] Add a config key to enable or disable S3 Multi-Tenancy feature

prashantpogde commented on code in PR #3397:
URL: https://github.com/apache/ozone/pull/3397#discussion_r869614222


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -3125,6 +3203,8 @@ public S3VolumeContext getS3VolumeContext() throws IOException {
           multiTenantManager.getTenantForAccessID(accessId);
 
       if (optionalTenantId.isPresent()) {
+        // To block all S3 multi-tenancy requests if disabled

Review Comment:
   Let's say initially multi-tenancy was enabled, and let's say we created the tenant volume and some buckets and keys. Now someone disables multi-tenancy. This point in code will take care of requests that will come through S3. What happens to access to multi-tenant volumes through ozone sh or OFS ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org