[GitHub] [incubator-inlong] EMsnap commented on a diff in pull request #4379: [INLONG-4353][Sort] Optimize code structure and shading jar

[GitBox <gi...@apache.org>]

EMsnap commented on code in PR #4379:
URL: https://github.com/apache/incubator-inlong/pull/4379#discussion_r881541366


##########
inlong-distribution/distribution.xml:
##########
@@ -70,6 +70,32 @@
                 <include>sort-dist-${project.version}.jar</include>
             </includes>
         </fileSet>
+        <fileSet>
+            <directory>../inlong-sort/sort-connectors/**/target/*</directory>
+            <outputDirectory>inlong-sort</outputDirectory>
+            <includes>
+                <include>sort-connector-hbase-${project.version}.jar</include>
+                <include>sort-connector-hive-${project.version}.jar</include>
+                <include>sort-connector-iceberg-${project.version}.jar</include>
+                <include>sort-connector-jdbc-${project.version}.jar</include>
+                <include>sort-connector-kafka-${project.version}.jar</include>
+                <include>sort-connector-mongodb-cdc-${project.version}.jar</include>
+                <include>sort-connector-mysql-cdc-${project.version}.jar</include>
+                <include>sort-connector-postgres-cdc-${project.version}.jar</include>
+                <include>sort-connector-pulsar-${project.version}.jar</include>
+                <include>sort-connector-sqlserver-cdc-${project.version}.jar</include>
+            </includes>
+        </fileSet>
+        <fileSet>
+            <directory>../inlong-sort/sort-formats/**/target/*</directory>
+            <outputDirectory>inlong-sort</outputDirectory>

Review Comment:
   inlong-sort/plugin/format may be better



##########
inlong-distribution/distribution.xml:
##########
@@ -70,6 +70,32 @@
                 <include>sort-dist-${project.version}.jar</include>
             </includes>
         </fileSet>
+        <fileSet>
+            <directory>../inlong-sort/sort-connectors/**/target/*</directory>
+            <outputDirectory>inlong-sort</outputDirectory>

Review Comment:
   inlong-sort/plugin/connectors may be better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org