You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/11/01 20:01:56 UTC

[GitHub] [activemq-artemis] gemmellr opened a new pull request #3832: ARTEMIS-3461: add some tests and resolve various issues spotted

gemmellr opened a new pull request #3832:
URL: https://github.com/apache/activemq-artemis/pull/3832


   ARTEMIS-3461: add some tests and resolve various issues spotted with the prior changes
   
   - Avoid blowing up on string bodies of any size if the valueSizeLimit bits are configured to disable limit.
   - Dont NPE if amqp-value + binary body is sent without a content-type, as it always should be.
   - Include expected prefix when adding delivery delay and ingress time annotations.
   - Use the actual name for ingress time annotation, as with all other annotations.
   - Use correct object type when testing equality with content-type value.
   - Use consistent case for 'groupId' in different properties.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3832: ARTEMIS-3461: add some tests and resolve various issues spotted

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3832:
URL: https://github.com/apache/activemq-artemis/pull/3832#issuecomment-956592089


   ... and when I started this task I thought it was going to be just an easy 5 min admin console fix :)
   
   
   thanks @gemmellr 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3832: ARTEMIS-3461: add some tests and resolve various issues spotted

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3832:
URL: https://github.com/apache/activemq-artemis/pull/3832#issuecomment-956592089


   ... and when I started this task I thought it was going to be just an easy 5 min admin console fix :)
   
   
   thanks @gemmellr 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic merged pull request #3832: ARTEMIS-3461: add some tests and resolve various issues spotted

Posted by GitBox <gi...@apache.org>.
clebertsuconic merged pull request #3832:
URL: https://github.com/apache/activemq-artemis/pull/3832


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic merged pull request #3832: ARTEMIS-3461: add some tests and resolve various issues spotted

Posted by GitBox <gi...@apache.org>.
clebertsuconic merged pull request #3832:
URL: https://github.com/apache/activemq-artemis/pull/3832


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3832: ARTEMIS-3461: add some tests and resolve various issues spotted

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3832:
URL: https://github.com/apache/activemq-artemis/pull/3832#issuecomment-956592089


   ... and when I started this task I thought it was going to be just an easy 5 min admin console fix :)
   
   
   thanks @gemmellr 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic merged pull request #3832: ARTEMIS-3461: add some tests and resolve various issues spotted

Posted by GitBox <gi...@apache.org>.
clebertsuconic merged pull request #3832:
URL: https://github.com/apache/activemq-artemis/pull/3832


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org