[GitHub] [accumulo] keith-turner commented on a change in pull request #1205: Fix #822 Add thread-safety info to AccumuloClient javadoc

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #1205: Fix #822 Add thread-safety info to AccumuloClient javadoc
URL: https://github.com/apache/accumulo/pull/1205#discussion_r293879121
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/client/AccumuloClient.java
 ##########
 @@ -54,6 +54,13 @@
  * creating them could perform worse than Connector. Therefore, it would be better to create an
  * AccumuloClient and pass it around.
  *
+ * <p>
+ * AccumuloClient objects are intended to be thread-safe, and can be used by multiple threads.
+ * However, care should be taken to ensure that the client is eventually closed, to clean up any
+ * resources in use in the client application when all threads are finished with the AccumuloClient
 
 Review comment:
   This sounds great.  Now we need to document thread safety for the scanner and batch writer, if its not already done.
   
   This information about closing overlaps a bit with information in the previous paragraph.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services