You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/04 09:08:05 UTC

[jira] [Commented] (JENA-1074) Add find operations for DatasetGraph for the union graph.

    [ https://issues.apache.org/jira/browse/JENA-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036216#comment-16036216 ] 

ASF GitHub Bot commented on JENA-1074:
--------------------------------------

GitHub user afs opened a pull request:

    https://github.com/apache/jena/pull/260

    JENA-1074: Provide a union graph for DatasetGraph

    This PR adds:
    
    `DatasetGraph.getUnionGraph`
    `Dataset.getUnionModel`
    
    It also adds a convenience `Graph.find()`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afs/jena jena1074_uniongraph

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jena/pull/260.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #260
    
----
commit a6eaa15da666981443dbb803905439449850a7ba
Author: Andy Seaborne <an...@apache.org>
Date:   2017-06-03T21:37:08Z

    Improve javadoc

commit 97e950e76023eb698fb369e621d246861be79e97
Author: Andy Seaborne <an...@apache.org>
Date:   2017-06-03T21:38:01Z

    Block ExtendedIterator.remove

commit c25cbd8bd33cfb08c8a04d0b7f228b361be76f6c
Author: Andy Seaborne <an...@apache.org>
Date:   2017-06-04T08:41:11Z

    JENA-1074: Add Graph.find(), equivalent to find(ANY,ANY,ANY).

commit 462fe53a8fbac8770471251be676a050d29a4d1a
Author: Andy Seaborne <an...@apache.org>
Date:   2017-06-04T08:43:25Z

    JENA-1074: Use DatasetGraph.findNG for dynamic union graph .find.

commit 0a872489d859a78cf0e9e13b2a8ce532a5751d5d
Author: Andy Seaborne <an...@apache.org>
Date:   2017-06-04T08:44:34Z

    JENA-1074: Add DatasetGraph.getUnionGraph
    
    A graph which is the triples fromall named graph in the dataset.
    This does not include the default graph.

commit a0169161322a6d65227e0c40cf464a0c879f1af2
Author: Andy Seaborne <an...@apache.org>
Date:   2017-06-04T08:55:15Z

    JENA-1074: Tests for DatasetGraph.getUnionGraph()

commit 8a6ad81cb4692790b6afe2268c2d7310da035cda
Author: Andy Seaborne <an...@apache.org>
Date:   2017-06-04T08:57:34Z

    JENA-1074: Provide Dataset.getUnionModel()

----


> Add find operations for DatasetGraph for the union graph.
> ---------------------------------------------------------
>
>                 Key: JENA-1074
>                 URL: https://issues.apache.org/jira/browse/JENA-1074
>             Project: Apache Jena
>          Issue Type: Brainstorming
>          Components: ARQ
>    Affects Versions: Jena 3.0.0
>            Reporter: Andy Seaborne
>            Priority: Minor
>
> (This follows on from JENA-1064)
> {{DatasetGraphBaseFind}} now has a {{find}} operations for the union graph added to make implementation easier.
> Should operation(s) be exposed in the core interface {{DatasetGraph}} (the application contract)? If so, how?
> The operations to consider include:
> * {{findInUnionGraph}} ({{Iterator<Triple>}})
> * {{findQuadsInUnionGraph}} ({{Iterator<Quad>}})
> * {{findInDftGraph}} ({{Iterator<Quad>}} - inconsistent naming with above)
> At the moment {{findInDftGraph}} returns quads and documents {{DatasetGraph.getDefaultGraph().find()}} as being the way to get triples. This suggests a different style where {{DatasetGraph}} has:
> * {{DatasetGraph.getUnionGraph()}}
> * {{DatasetGraphFind.findInUnionGraph}} ({{Iterator<Quad>}})



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)