[jira] [Commented] (OAK-3294) Read-only live FileStore implementation

["Francesco Mari (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14713045#comment-14713045 ] 

Francesco Mari commented on OAK-3294:
-------------------------------------

[~alex.parvulescu], the patch looks good to me. I would add {{compact()}} and {{maybeCompact()}} to {{ReadOnlyStore}} as no-op operations, because these methods are conceptually associated to a change in the {{FileStore}} on the file system. 

I'm also not sure the methods overridden in {{ReadOnlyStore}} should be implemented as no-op, or they should perform some more meaningful action, such as writing a log message or throwing an {{UnsuportedOperationException}} when called. I'm in favour of throwing an exception.

> Read-only live FileStore implementation
> ---------------------------------------
>
>                 Key: OAK-3294
>                 URL: https://issues.apache.org/jira/browse/OAK-3294
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segmentmk
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>            Priority: Minor
>         Attachments: OAK-3294.patch
>
>
> Having a read-only FileStore able to work on a running (live) FileStore would open the door for some interesting data collection & debugging tools that no longer need the repository to be shut down.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)