You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2004/06/03 07:29:29 UTC

DO NOT REPLY [Bug 27929] - [PATCH] Opening XLS file with drop down list throws ArrayIndexOutofBoundsException

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=27929>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27929

[PATCH] Opening XLS file with drop down list throws ArrayIndexOutofBoundsException

zalewski@optonline.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Opening XLS file with drop  |[PATCH] Opening XLS file
                   |down list throws            |with drop down list throws
                   |ArrayIndexOutofBoundsExcepti|ArrayIndexOutofBoundsExcepti
                   |on                          |on



------- Additional Comments From zalewski@optonline.net  2004-06-03 05:29 -------
Here is an alternate patch, with JUnit Testcases.

I came up with almost the same solution as Roland except

1) I adjusted the size in the static method SubRecord.createSubRecord(). I
    also set the sub record size to 0 if it is ever negative.
2) I adjusted the size of the subrecord to 4 less than the total size of the
    OBJ record. The last 4 bytes of an OBJ record should always be an ftEnd
    subrecord, and this appears to be the case with Autofilters and dropdown
    boxes inserted via the Forms toolbar.
3) I adjusted Obj.java to advance the offset by SubRecord.getRecordSize()
    (instead of 4 + subRecordSize). The value of subRecordSize may not be
    reliable.

The patch includes new JUnit Testcases for the modified SubRecord.java and 
ObjRecord.java. These tests fail with the 2.5 as pulled yesterday, but work 
with the changes in the patch file.

---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: poi-dev-help@jakarta.apache.org