[GitHub] [incubator-pagespeed-mod] jmarantz commented on issue #2070: Support Request: "not a valid experiment spec" - "ModPagespeedExperimentSpec id=1;percent=50;default"

[GitBox <gi...@apache.org>]

jmarantz commented on issue #2070:
URL: https://github.com/apache/incubator-pagespeed-mod/issues/2070#issuecomment-997212612


   You are right that no one is actively working on the feature, but if there's some usage issues you might want to refer to the test code which can clarify with precision what valid syntax is. The test for the experiment-matcher is here: 
   
   https://github.com/apache/incubator-pagespeed-mod/blob/master/test/net/instaweb/rewriter/experiment_matcher_test.cc
   
   and there are other related tests here:
   
   https://github.com/apache/incubator-pagespeed-mod/blob/master/test/net/instaweb/rewriter/experiment_util_test.cc
   
   These tests may help give clues as to what's valid syntax. Of course there's also the implementation files:
   
   https://github.com/apache/incubator-pagespeed-mod/blob/master/net/instaweb/rewriter/experiment_matcher.cc
   
   and
   
   https://github.com/apache/incubator-pagespeed-mod/blob/master/net/instaweb/rewriter/experiment_util.cc
   
   Sorry I don't have more specific advice for you -- I had high level knowledge of this filter and why we built it but didn't actively work on it myself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pagespeed.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org