You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Eric Gillespie <ep...@pretzelnet.org> on 2002/06/12 20:11:25 UTC

[PATCH] configure does not find apr{,-util} in /usr/local/apache2

The problem was that the apr macros don't search the standard paths
unless a third argument of 1 is passed to them, that's kinda silly,
but this is a simple fix.

Index: ./ac-helpers/aprutil.m4
===================================================================
--- ./ac-helpers/aprutil.m4
+++ ./ac-helpers/aprutil.m4	Wed Jun 12 14:59:53 2002
@@ -14,7 +14,7 @@
 [
   AC_MSG_NOTICE([Apache Portable Runtime Utility (APRUTIL) library configuration])
 
-  APR_FIND_APU("$srcdir/apr-util", "./apr-util")
+  APR_FIND_APU("$srcdir/apr-util", "./apr-util", 1)
 
   if test $apu_found = "no"; then
     AC_MSG_WARN([APRUTIL not found])
Index: ./ac-helpers/apr.m4
===================================================================
--- ./ac-helpers/apr.m4
+++ ./ac-helpers/apr.m4	Wed Jun 12 14:59:15 2002
@@ -9,7 +9,7 @@
 [
   AC_MSG_NOTICE([Apache Portable Runtime (APR) library configuration])
 
-  APR_FIND_APR("$srcdir/apr", "./apr")
+  APR_FIND_APR("$srcdir/apr", "./apr", 1)
 
   if test $apr_found = "no"; then
     AC_MSG_WARN([APR not found])

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Log message for [PATCH] configure does not find apr{,-util} in /usr/local/apache2

Posted by Eric Gillespie <ep...@pretzelnet.org>.
Philip Martin <ph...@codematters.co.uk> writes:

> I tried it and it didn't work.  I don't normally build with apr in the
> tree so I may have got something wrong.

I just tested this and it worked.  I put apr and apr-util into my
svn source directory, and configure found and used them.  I then
uninstalled apr and apr-util, and the configure script still found
the ones in the svn source directory.

Here's the log message:

Find apr and apr-util in standard installation directories in
addition directories on the PATH and in the svn source directory.

* apr.m4
  Pass 1 as the third argument to APR_FIND_APR.
* aprutil.m4
  Pass 1 as the third argument to APR_FIND_APU.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] configure does not find apr{,-util} in /usr/local/apache2

Posted by Philip Martin <ph...@codematters.co.uk>.
Eric Gillespie <ep...@pretzelnet.org> writes:

> Philip Martin <ph...@codematters.co.uk> writes:
> 
> > This appears to stop configure finding apr and apr-util in the
> > Subversion source dir.
> 
> Are you sure?  I have not tested that, but i don't see how it would
> happen.  If the third argument is passed, it tries to find apr in
> a few standard directories.  Whether it finds one or not, it then
> unconditionally looks at the first argument and prefers it if it
> exists.

I tried it and it didn't work.  I don't normally build with apr in the
tree so I may have got something wrong.

-- 
Philip

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] configure does not find apr{,-util} in /usr/local/apache2

Posted by Eric Gillespie <ep...@pretzelnet.org>.
Philip Martin <ph...@codematters.co.uk> writes:

> This appears to stop configure finding apr and apr-util in the
> Subversion source dir.

Are you sure?  I have not tested that, but i don't see how it would
happen.  If the third argument is passed, it tries to find apr in
a few standard directories.  Whether it finds one or not, it then
unconditionally looks at the first argument and prefers it if it
exists.

--  
Eric Gillespie <*> epg@pretzelnet.org

Conformity is a sin.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] configure does not find apr{,-util} in /usr/local/apache2

Posted by Justin Erenkrantz <je...@apache.org>.
On Wed, Jun 12, 2002 at 10:45:06PM +0100, Philip Martin wrote:
> This appears to stop configure finding apr and apr-util in the
> Subversion source dir.

You're right, it prohibits the source dir from being used if
there is an installed copy of APR.

I added this safety check because Karl and Ben kept running into
problems with conflicts between their installed copies and their
in-tree copies.  So, IMHO, this patch can't be applied until APR
is officially released and the APIs are frozen.  -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] configure does not find apr{,-util} in /usr/local/apache2

Posted by Philip Martin <ph...@codematters.co.uk>.
Eric Gillespie <ep...@pretzelnet.org> writes:

> The problem was that the apr macros don't search the standard paths
> unless a third argument of 1 is passed to them, that's kinda silly,
> but this is a simple fix.
> 
> Index: ./ac-helpers/aprutil.m4
> ===================================================================
> --- ./ac-helpers/aprutil.m4
> +++ ./ac-helpers/aprutil.m4	Wed Jun 12 14:59:53 2002
> @@ -14,7 +14,7 @@
>  [
>    AC_MSG_NOTICE([Apache Portable Runtime Utility (APRUTIL) library configuration])
>  
> -  APR_FIND_APU("$srcdir/apr-util", "./apr-util")
> +  APR_FIND_APU("$srcdir/apr-util", "./apr-util", 1)
>  
>    if test $apu_found = "no"; then
>      AC_MSG_WARN([APRUTIL not found])
> Index: ./ac-helpers/apr.m4
> ===================================================================
> --- ./ac-helpers/apr.m4
> +++ ./ac-helpers/apr.m4	Wed Jun 12 14:59:15 2002
> @@ -9,7 +9,7 @@
>  [
>    AC_MSG_NOTICE([Apache Portable Runtime (APR) library configuration])
>  
> -  APR_FIND_APR("$srcdir/apr", "./apr")
> +  APR_FIND_APR("$srcdir/apr", "./apr", 1)
>  
>    if test $apr_found = "no"; then
>      AC_MSG_WARN([APR not found])

This appears to stop configure finding apr and apr-util in the
Subversion source dir.

It helps if you can supply a log message with your patch, then we
don't have to think one up.

-- 
Philip

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] configure does not find apr{,-util} in /usr/local/apache2

Posted by Justin Erenkrantz <je...@apache.org>.
On Tue, Aug 06, 2002 at 10:06:01AM -0500, Karl Fogel wrote:
> I was asking about Daniel's archive, where I didn't see any search
> capability at all.  Did you find some, or are you talking about the
> tigris.org search feature?
> 
> If Daniel's archive had good searching, that would be huge... :-)

I misread your post.  Sorry.  I meant tigris.org's.  -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] configure does not find apr{,-util} in /usr/local/apache2

Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Justin Erenkrantz <je...@apache.org> writes:
> > Am I missing something, or does it just not offer searching?
> 
> It took about 5 minutes to search on the subject line above
> and it returned lots of invalid hits (none of them were of the
> thread I wanted!).

I was asking about Daniel's archive, where I didn't see any search
capability at all.  Did you find some, or are you talking about the
tigris.org search feature?

If Daniel's archive had good searching, that would be huge... :-)

-K


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] configure does not find apr{,-util} in /usr/local/apache2

Posted by Justin Erenkrantz <je...@apache.org>.
On Tue, Aug 06, 2002 at 09:49:32AM -0500, Karl Fogel wrote:
> Daniel Stenberg <da...@haxx.se> writes:
> > Lemme just silently and quietly remind people about an alternative web
> > archive of the svn dev list: http://www.contactor.se/~dast/svn/
> > 
> > It might not be a perfect version either, but it provides a different UI. :-)
> 
> Am I missing something, or does it just not offer searching?

It took about 5 minutes to search on the subject line above
and it returned lots of invalid hits (none of them were of the
thread I wanted!).

So, no, the search is pretty useless.  -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] configure does not find apr{,-util} in /usr/local/apache2

Posted by Daniel Stenberg <da...@haxx.se>.
On 6 Aug 2002, Karl Fogel wrote:

> Daniel Stenberg <da...@haxx.se> writes:
> > Lemme just silently and quietly remind people about an alternative web
> > archive of the svn dev list: http://www.contactor.se/~dast/svn/
> >
> > It might not be a perfect version either, but it provides a different UI.
> > :-)
>
> Am I missing something, or does it just not offer searching?

No, you're not missing anything, there's no search form for this archive.

Skip over too www.google.com and use that, include "site:www.contactor.se"
and "subversion" in the search field and it semi-works. At least for somewhat
older mails.

-- 
      Daniel Stenberg - http://daniel.haxx.se - +46-705-44 31 77
   ech`echo xiun|tr nu oc|sed 'sx\([sx]\)\([xoi]\)xo un\2\1 is xg'`ol


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] configure does not find apr{,-util} in /usr/local/apache2

Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Daniel Stenberg <da...@haxx.se> writes:
> Lemme just silently and quietly remind people about an alternative web
> archive of the svn dev list: http://www.contactor.se/~dast/svn/
> 
> It might not be a perfect version either, but it provides a different UI. :-)

Am I missing something, or does it just not offer searching?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] configure does not find apr{,-util} in /usr/local/apache2

Posted by Daniel Stenberg <da...@haxx.se>.
On Tue, 6 Aug 2002, Justin Erenkrantz wrote:

> Let's just say that tigris.org's mail archive UI is, uh, not very
> user-friendly.  -- justin

Lemme just silently and quietly remind people about an alternative web
archive of the svn dev list: http://www.contactor.se/~dast/svn/

It might not be a perfect version either, but it provides a different UI. :-)

-- 
      Daniel Stenberg - http://daniel.haxx.se - +46-705-44 31 77
   ech`echo xiun|tr nu oc|sed 'sx\([sx]\)\([xoi]\)xo un\2\1 is xg'`ol


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] configure does not find apr{,-util} in /usr/local/apache2

Posted by Justin Erenkrantz <je...@apache.org>.
On Mon, Aug 05, 2002 at 03:37:30PM -0500, Karl Fogel wrote:
> Er, do you happen to remember the thread, or have the old mail lying
> around?  (I almost wrote "laying about", then I realized that Brane
> would point out that that means something quite different.)

http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=15663

Let's just say that tigris.org's mail archive UI is, uh, not very
user-friendly.  -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] configure does not find apr{,-util} in /usr/local/apache2

Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Justin Erenkrantz <je...@apache.org> writes:
> On Mon, Aug 05, 2002 at 03:09:15PM -0500, Karl Fogel wrote:
> > Applying this seems desirable to me, but then I'm not much of an apr
> > configury expert.  Before I commit, does anyone see a reason not to
> > apply this patch?
> 
> I detailed the reasons why this should not be applied.  
> 
> My position still stands.  -- justin

Er, do you happen to remember the thread, or have the old mail lying
around?  (I almost wrote "laying about", then I realized that Brane
would point out that that means something quite different.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] configure does not find apr{,-util} in /usr/local/apache2

Posted by Justin Erenkrantz <je...@apache.org>.
On Mon, Aug 05, 2002 at 03:09:15PM -0500, Karl Fogel wrote:
> Applying this seems desirable to me, but then I'm not much of an apr
> configury expert.  Before I commit, does anyone see a reason not to
> apply this patch?

I detailed the reasons why this should not be applied.  

My position still stands.  -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] configure does not find apr{,-util} in /usr/local/apache2

Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Eric Gillespie <ep...@pretzelnet.org> writes:
> The problem was that the apr macros don't search the standard paths
> unless a third argument of 1 is passed to them, that's kinda silly,
> but this is a simple fix.

Applying this seems desirable to me, but then I'm not much of an apr
configury expert.  Before I commit, does anyone see a reason not to
apply this patch?

-Karl

> Index: ./ac-helpers/aprutil.m4
> ===================================================================
> --- ./ac-helpers/aprutil.m4
> +++ ./ac-helpers/aprutil.m4	Wed Jun 12 14:59:53 2002
> @@ -14,7 +14,7 @@
>  [
>    AC_MSG_NOTICE([Apache Portable Runtime Utility (APRUTIL) library configuration])
>  
> -  APR_FIND_APU("$srcdir/apr-util", "./apr-util")
> +  APR_FIND_APU("$srcdir/apr-util", "./apr-util", 1)
>  
>    if test $apu_found = "no"; then
>      AC_MSG_WARN([APRUTIL not found])
> Index: ./ac-helpers/apr.m4
> ===================================================================
> --- ./ac-helpers/apr.m4
> +++ ./ac-helpers/apr.m4	Wed Jun 12 14:59:15 2002
> @@ -9,7 +9,7 @@
>  [
>    AC_MSG_NOTICE([Apache Portable Runtime (APR) library configuration])
>  
> -  APR_FIND_APR("$srcdir/apr", "./apr")
> +  APR_FIND_APR("$srcdir/apr", "./apr", 1)
>  
>    if test $apr_found = "no"; then
>      AC_MSG_WARN([APR not found])
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org