You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2023/03/11 03:43:15 UTC

[spark] branch branch-3.4 updated: [SPARK-42721][CONNECT][FOLLOWUP] Apply scalafmt to LoggingInterceptor

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch branch-3.4
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.4 by this push:
     new 67ccd8fff11 [SPARK-42721][CONNECT][FOLLOWUP] Apply scalafmt to LoggingInterceptor
67ccd8fff11 is described below

commit 67ccd8fff112a5233e8ac44be888fc3484b3d082
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Fri Mar 10 19:42:55 2023 -0800

    [SPARK-42721][CONNECT][FOLLOWUP] Apply scalafmt to LoggingInterceptor
    
    ### What changes were proposed in this pull request?
    
    This is a follow-up to fix Scala linter failure at `LoggingInterceptor.scala`.
    
    ### Why are the changes needed?
    
    To recover CI.
    
    - **master**: https://github.com/apache/spark/actions/runs/4389407261/jobs/7686936044
    - **branch-3.4**: https://github.com/apache/spark/actions/runs/4389407870/jobs/7686935027
    ```
    The scalafmt check failed on connector/connect at following occurrences:
    
    Requires formatting: LoggingInterceptor.scala
    
    Before submitting your change, please make sure to format your code using the following command:
    ./build/mvn -Pscala-2.12 scalafmt:format -Dscalafmt.skip=false -Dscalafmt.validateOnly=false -Dscalafmt.changedOnly=false -pl connector/connect/common -pl connector/connect/server -pl connector/connect/client/jvm
    Error: Process completed with exit code 1.
    ```
    
    ### Does this PR introduce _any_ user-facing change?
    
    No
    
    ### How was this patch tested?
    
    Pass the CI.
    
    Closes #40374 from dongjoon-hyun/SPARK-42721.
    
    Authored-by: Dongjoon Hyun <do...@apache.org>
    Signed-off-by: Dongjoon Hyun <do...@apache.org>
    (cherry picked from commit 967ce371ba1645d9a24dbf01a1b64faf569e8863)
    Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
 .../org/apache/spark/sql/connect/service/LoggingInterceptor.scala   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/LoggingInterceptor.scala b/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/LoggingInterceptor.scala
index c91075fd127..2d848d3c840 100644
--- a/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/LoggingInterceptor.scala
+++ b/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/LoggingInterceptor.scala
@@ -31,9 +31,9 @@ import io.grpc.ServerInterceptor
 import org.apache.spark.internal.Logging
 
 /**
- * A gRPC interceptor to log RPC requests and responses. It logs the protobufs as JSON.
- * Useful for local development. An ID is logged for each RPC so that requests and corresponding
- * responses can be exactly matched.
+ * A gRPC interceptor to log RPC requests and responses. It logs the protobufs as JSON. Useful for
+ * local development. An ID is logged for each RPC so that requests and corresponding responses
+ * can be exactly matched.
  */
 class LoggingInterceptor extends ServerInterceptor with Logging {
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org