You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "yuseok89 (via GitHub)" <gi...@apache.org> on 2026/10/07 02:07:51 UTC
[PR] Fix manual dagrun outside task date window v2 [airflow]
yuseok89 opened a new pull request, #74387:
URL: https://github.com/apache/airflow/pull/74387
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
closes: #38513
related: #71758
A Dag run whose logical date falls outside a task's `start_date` / `end_date` window creates no task instance for that task. When every task is filtered out this way, the run has no task instances and is immediately reported as success without anything having run.
Backfill runs were already exempt from this window. Every run type except scheduled runs is now exempt too, so the window only limits what the scheduler creates.
## Improvements over #71758
- #71758 only exempted manual runs. Runs created by `TriggerDagRunOperator` (`operator_triggered`) and asset materialization runs still ended up empty, so they are covered now. The condition is `run_type != SCHEDULED`, which also covers run types added later.
- The FAQ has a dedicated entry on which runs the dates apply to. It covers a task whose `end_date` has passed, which now runs in manual runs, and the `depends_on_past=True` with `catchup=False` case, which needs `ignore_first_depends_on_past=True`.
## Verified in the UI
A Dag with a `start_date` of 2050 and three chained `@task` functions (`extract` → `transform` → `load`).
### Before
https://github.com/user-attachments/assets/fd8a57c2-c5c9-4ecf-b0ce-65e49f543dc6
### After
https://github.com/user-attachments/assets/eec34244-c5b2-43ad-bfcc-92baeefb613f
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [x] Yes (please specify the tool below)
- Claude Code (Opus 5.5)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ignore task start_date and end_date outside scheduled runs [airflow]
Posted by "yuseok89 (via GitHub)" <gi...@apache.org>.
yuseok89 commented on PR #74387:
URL: https://github.com/apache/airflow/pull/74387#issuecomment-6267499024
Thanks for taking a look, and for explaining the reasoning on the issue as well. I picked this up because #38513 had been open for a long time, and I think it is worth getting long-standing issues to a clear answer either way, so this already helps. I'm glad we can continue the discussion there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ignore task start_date and end_date outside scheduled runs [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #74387:
URL: https://github.com/apache/airflow/pull/74387#issuecomment-6260554711
Sorry, this is a no, merging this world be a massive breaking change.
Task start dates are an explicit signal by the dag author of this is the earliest point this task can run - it doesn't matter if that is triggered or scheduled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ignore task start_date and end_date outside scheduled runs [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #74387:
URL: https://github.com/apache/airflow/pull/74387#issuecomment-6258165138
I’m not entirely convinced it’s a good idea to blanket-ignore those values for manual runs. It is plausible that some users currently use start_date to gate tasks from being run until a future date, which is what the argument is originally intend for. This change would be breaking for those users.
Maybe it would make sense to add a flag on dag run triggering to optionally ignore task-level start/end dates, but that’d be a noticeably larger change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Ignore task start_date and end_date outside scheduled runs [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb closed pull request #74387: Ignore task start_date and end_date outside scheduled runs
URL: https://github.com/apache/airflow/pull/74387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org