You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/09/05 07:34:25 UTC
[GitHub] [iceberg] hililiwei opened a new pull request #3076: Doc:Add escape in the SQL statement in the flink engine document
hililiwei opened a new pull request #3076:
URL: https://github.com/apache/iceberg/pull/3076
about https://github.com/apache/iceberg/issues/3075
the default keyword is used in the SQL statement in the Flink document, but the example does not add escape, so the statement cannot be run directly.
such as：
CREATE TABLE hive_catalog.default.sample (
id BIGINT COMMENT 'unique id',
data STRING
);
An error will be reported when the statement is executed：
[ERROR] Could not execute SQL statement. Reason:
org.apache.flink.sql.parser.impl.ParseException: Encountered ". default" at line 1, column 27.
modify the SQL：
CREATE TABLE hive_catalog.`default`.sample (
id BIGINT COMMENT 'unique id',
data STRING
);
the above statements can be executed normally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] openinx commented on pull request #3076: Doc:Add escape in the SQL statement in the flink engine document
Posted by GitBox <gi...@apache.org>.
openinx commented on pull request #3076:
URL: https://github.com/apache/iceberg/pull/3076#issuecomment-913592305
Get this merged, Thanks @hililiwei for contributing !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] openinx commented on a change in pull request #3076: Doc:Add escape in the SQL statement in the flink engine document
Posted by GitBox <gi...@apache.org>.
openinx commented on a change in pull request #3076:
URL: https://github.com/apache/iceberg/pull/3076#discussion_r702720426
##########
File path: site/docs/flink.md
##########
@@ -270,7 +270,7 @@ USE iceberg_db;
### `CREATE TABLE`
```sql
-CREATE TABLE hive_catalog.default.sample (
+CREATE TABLE hive_catalog.`default`.sample (
Review comment:
Thanks @hililiwei to address this issue, I think we can quote all the identifiers (include catalog identifier, database name, table name) , that looks more unified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] openinx merged pull request #3076: Doc:Add escape in the SQL statement in the flink engine document
Posted by GitBox <gi...@apache.org>.
openinx merged pull request #3076:
URL: https://github.com/apache/iceberg/pull/3076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hililiwei commented on a change in pull request #3076: Doc:Add escape in the SQL statement in the flink engine document
Posted by GitBox <gi...@apache.org>.
hililiwei commented on a change in pull request #3076:
URL: https://github.com/apache/iceberg/pull/3076#discussion_r702839311
##########
File path: site/docs/flink.md
##########
@@ -270,7 +270,7 @@ USE iceberg_db;
### `CREATE TABLE`
```sql
-CREATE TABLE hive_catalog.default.sample (
+CREATE TABLE hive_catalog.`default`.sample (
Review comment:
Thanks.Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org