You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/09/14 15:55:22 UTC
[GitHub] incubator-brooklyn pull request: Fix docs for release / links
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/892
Fix docs for release / links
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/892.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #892
----
commit c960f9974e6c52521ab4dbebc18f65f29d04d010
Author: Aled Sage <al...@gmail.com>
Date: 2015-09-14T13:53:42Z
Update release instructions
commit acfa315985ed38042398083b128dd3a953fe5a2d
Author: Aled Sage <al...@gmail.com>
Date: 2015-09-14T13:54:03Z
Fix links in docs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix docs for release / links
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/892#discussion_r39550112
--- Diff: docs/website/developers/committers/release-process/publish.md ---
@@ -69,12 +74,15 @@ link in the top right (the credentials are the same as your Git and Jenkins cred
Repositories" page, and tick the repository with the name starting `orgapachebrooklyn`. Click the **Release** button.
Provide a description which includes the version, e.g. `Apache Brooklyn 0.7.0-incubating`.
+Note the staging repository may have a name like "080 RC2". You can double-check under the "content" that brooklyn-dist
--- End diff --
This name is unimportant, it only exists for the duration of the RC vote, and there should only ever be one Brooklyn staging repository possible at a time. So it doesn't really matter what it's called. Write a haiku, or a even short freestyle rap :headphones:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix docs for release / links
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/892#issuecomment-140723652
Thanks; have incorporated comments. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix docs for release / links
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/892#discussion_r39397143
--- Diff: docs/website/developers/committers/release-process/publish.md ---
@@ -124,6 +150,8 @@ Tag the release in git
Make a signed tag for this release, based on the tag for the release candidate, and then push the tag:
{% highlight bash %}
+git checkout ${VERSION_NAME}
--- End diff --
This line should be unnecessary, as the `git tag` command on the next line explicitly places the tag on the commit `apache-brooklyn-${VERSION_NAME}-rc${RC_NUMBER}`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix docs for release / links
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/892#discussion_r39492061
--- Diff: docs/website/developers/committers/release-process/publish.md ---
@@ -69,12 +74,15 @@ link in the top right (the credentials are the same as your Git and Jenkins cred
Repositories" page, and tick the repository with the name starting `orgapachebrooklyn`. Click the **Release** button.
Provide a description which includes the version, e.g. `Apache Brooklyn 0.7.0-incubating`.
+Note the staging repository may have a name like "080 RC2". You can double-check under the "content" that brooklyn-dist
--- End diff --
My point was just that the name will likely say "release candidate". When I did this step, I wasn't sure if I should see a staging repo for the 0.8.0-incubating that I had just pushed to `apache-dist-release-brooklyn`. I was not confident about pushing the RC staging repo until I'd checked with you @rdowner
I'll reword it, but will not delete this paragraph.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix docs for release / links
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/892#discussion_r39533678
--- Diff: docs/website/developers/committers/release-process/publish.md ---
@@ -69,12 +74,15 @@ link in the top right (the credentials are the same as your Git and Jenkins cred
Repositories" page, and tick the repository with the name starting `orgapachebrooklyn`. Click the **Release** button.
Provide a description which includes the version, e.g. `Apache Brooklyn 0.7.0-incubating`.
+Note the staging repository may have a name like "080 RC2". You can double-check under the "content" that brooklyn-dist
--- End diff --
hey - sorry, it needed a name for the staging repo but it didn't seem to matter what it was so yes i put `080-RC2`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix docs for release / links
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/892
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix docs for release / links
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/892#discussion_r39533783
--- Diff: docs/website/developers/committers/release-process/publish.md ---
@@ -69,12 +74,15 @@ link in the top right (the credentials are the same as your Git and Jenkins cred
Repositories" page, and tick the repository with the name starting `orgapachebrooklyn`. Click the **Release** button.
Provide a description which includes the version, e.g. `Apache Brooklyn 0.7.0-incubating`.
+Note the staging repository may have a name like "080 RC2". You can double-check under the "content" that brooklyn-dist
--- End diff --
i don't think we need the added text as the RM will have given the repo name. it won't look like `080-RC2` unless it was me :) .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix docs for release / links
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/892#discussion_r39396989
--- Diff: docs/website/developers/committers/release-process/make-release-artifacts.md ---
@@ -54,5 +54,5 @@ Make a signed tag for this release, and then push the tag:
{% highlight bash %}
git tag -s -m "Tag release ${VERSION_NAME} release candidate ${RC_NUMBER}" apache-brooklyn-${VERSION_NAME}-rc${RC_NUMBER}
-git push origin apache-brooklyn-${VERSION_NAME}-rc${RC_NUMBER}
+git push apache apache-brooklyn-${VERSION_NAME}-rc${RC_NUMBER}
--- End diff --
The origin name depends on how the remote was added (or the repository originally cloned); but someone following the release instructions at https://brooklyn.incubator.apache.org/developers/committers/merging-contributed-code.html will have the upstream remote named `apache`, so this is the "right" change IMO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix docs for release / links
Posted by rdowner <gi...@git.apache.org>.
Github user rdowner commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/892#discussion_r39396848
--- Diff: docs/website/developers/committers/release-process/publish.md ---
@@ -69,12 +74,15 @@ link in the top right (the credentials are the same as your Git and Jenkins cred
Repositories" page, and tick the repository with the name starting `orgapachebrooklyn`. Click the **Release** button.
Provide a description which includes the version, e.g. `Apache Brooklyn 0.7.0-incubating`.
+Note the staging repository may have a name like "080 RC2". You can double-check under the "content" that brooklyn-dist
--- End diff --
The name will be whatever the RM gave in https://brooklyn.incubator.apache.org/developers/committers/release-process/publish-temp.html#close-the-staging-repository-on-apaches-nexus-server. That page suggested using a name like `Apache Brooklyn 0.7.0-incubating-rc1`; Alex seems to have picked something much more terse.
I'd remove this change; I suggested you do it since the RM changed partway through the release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---