[jira] [Work logged] (GOBBLIN-1992) Allow per job level logging in Gobblin Temporal workflows

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1992?focusedWorklogId=901837&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-901837 ]

ASF GitHub Bot logged work on GOBBLIN-1992:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Jan/24 04:11
            Start Date: 26/Jan/24 04:11
    Worklog Time Spent: 10m 
      Work Description: Will-Lo opened a new pull request, #3868:
URL: https://github.com/apache/gobblin/pull/3868

   …al Gobblin workflows
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1992
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if applicable):
   
   Currently the Temporal job context does not include the job metadata e.g. flow name, flow group, flow execution ID, which is critical for debugging workflows in the temporal cluster.
   
   We want to have per job logging so that it is easier to debug multiple Gobblin workflows on Temporal sent through GaaS.
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Example logs can have this format (given the correct log4j property)
   ```
   2024-01-25 20:02:40 PST WARN  [flow.group:iceberg-persist-wus-EmailFeedbackEvent flow.name:iceberg-persist-wus-EmailFeedbackEvent flow.executionId:iceberg-persist-wus-EmailFeedbackEvent] [TaskExecutor-0] org.apache.gobblin.runtime.Task  - Synchronous task execution model is deprecated. Please consider using stream model.
   2024-01-25 20:02:40 PST INFO  [flow.group:iceberg-persist-wus-EmailFeedbackEvent flow.name:iceberg-persist-wus-EmailFeedbackEvent flow.executionId:iceberg-persist-wus-EmailFeedbackEvent] [Activity Executor taskQueue="GobblinTemporalDDM2PoCTaskQueue", namespace="gobblin-fastingest-internpoc": 1] org.apache.gobblin.runtime.GobblinMultiTaskAttempt  - Waiting for submitted tasks of job job_kip-test_iceberg-persist-wus-EmailFeedbackEvent_IcebergBasedDistcpToHdfs_holdem-oh-iceberg_war-oh-iceberg_inter-cluster-oh-iceberg-based-copy_0_1705956881307 to complete in container container-id-for-wu-0...
   2024-01-25 20:02:40 PST INFO  [flow.group:iceberg-persist-wus-EmailFeedbackEvent flow.name:iceberg-persist-wus-EmailFeedbackEvent flow.executionId:iceberg-persist-wus-EmailFeedbackEvent] [Activity Executor taskQueue="GobblinTemporalDDM2PoCTaskQueue", namespace="gobblin-fastingest-internpoc": 1] org.apache.gobblin.runtime.GobblinMultiTaskAttempt  - 1 out of 1 tasks of job job_kip-test_iceberg-persist-wus-EmailFeedbackEvent_IcebergBasedDistcpToHdfs_holdem-oh-iceberg_war-oh-iceberg_inter-cluster-oh-iceberg-based-copy_0_1705956881307 are running in container container-id-for-wu-0. 0 tasks finished.
   2024-01-25 20:02:40 PST INFO  [flow.group:iceberg-persist-wus-EmailFeedbackEvent flow.name:iceberg-persist-wus-EmailFeedbackEvent flow.executionId:iceberg-persist-wus-EmailFeedbackEvent] [TaskExecutor-0] org.apache.gobblin.runtime.TaskExecutor  - Submitting fork 0 of task task_kip-test_iceberg-persist-wus-EmailFeedbackEvent_IcebergBasedDistcpToHdfs_holdem-oh-iceberg_war-oh-iceberg_inter-cluster-oh-iceberg-based-copy_0_1705956881307_0
   2024-01-25 20:02:40 PST INFO  [flow.group:iceberg-persist-wus-EmailFeedbackEvent flow.name:iceberg-persist-wus-EmailFeedbackEvent flow.executionId:iceberg-persist-wus-EmailFeedbackEvent] [TaskExecutor-0] org.apache.gobblin.runtime.Task  - Task mode streaming = false
   ```
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 901837)
    Remaining Estimate: 0h
            Time Spent: 10m

> Allow per job level logging in Gobblin Temporal workflows
> ---------------------------------------------------------
>
>                 Key: GOBBLIN-1992
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1992
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: William Lo
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently the Temporal job context does not include the job metadata e.g. flow name, flow group, flow execution ID, which is critical for debugging workflows in the temporal cluster.
> We want to have per job logging so that it is easier to debug multiple Gobblin workflows on Temporal sent through GaaS.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)