You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/09/13 14:48:22 UTC
[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request, #1417: MINIFICPP-1834 Add VERSIONINFO resource file
fgerlits opened a new pull request, #1417:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1417
https://issues.apache.org/jira/browse/MINIFICPP-1834
This adds version number, description, and some other info to the Windows binary. To access this info, right-click on the executable file in a file explorer, select Properties and then the Details tab. See sample screenshots in the Jira.
---
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1417: MINIFICPP-1834 Add VERSIONINFO resource file
Posted by GitBox <gi...@apache.org>.
szaszm commented on code in PR #1417:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1417#discussion_r969736243
##########
CMakeLists.txt:
##########
@@ -20,7 +20,7 @@
cmake_minimum_required(VERSION 3.17)
cmake_policy(SET CMP0096 NEW) # policy to preserve the leading zeros in PROJECT_VERSION_{MAJOR,MINOR,PATCH,TWEAK}
cmake_policy(SET CMP0065 OLD) # default export policy, required for self-dlopen
-project(nifi-minifi-cpp VERSION 0.12.0)
+project(nifi-minifi-cpp VERSION 0.13.0)
Review Comment:
There is another version number in libminifi/CMakeLists.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez closed pull request #1417: MINIFICPP-1834 Add VERSIONINFO resource file
Posted by GitBox <gi...@apache.org>.
lordgamez closed pull request #1417: MINIFICPP-1834 Add VERSIONINFO resource file
URL: https://github.com/apache/nifi-minifi-cpp/pull/1417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1417: MINIFICPP-1834 Add VERSIONINFO resource file
Posted by GitBox <gi...@apache.org>.
fgerlits commented on code in PR #1417:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1417#discussion_r969741727
##########
CMakeLists.txt:
##########
@@ -20,7 +20,7 @@
cmake_minimum_required(VERSION 3.17)
cmake_policy(SET CMP0096 NEW) # policy to preserve the leading zeros in PROJECT_VERSION_{MAJOR,MINOR,PATCH,TWEAK}
cmake_policy(SET CMP0065 OLD) # default export policy, required for self-dlopen
-project(nifi-minifi-cpp VERSION 0.12.0)
+project(nifi-minifi-cpp VERSION 0.13.0)
Review Comment:
thanks -- fixed in 85fb3f6dbccb8588774173d2b80c832c07e27054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1417: MINIFICPP-1834 Add VERSIONINFO resource file
Posted by GitBox <gi...@apache.org>.
szaszm commented on code in PR #1417:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1417#discussion_r974412364
##########
versioninfo.rc.in:
##########
@@ -0,0 +1,44 @@
+#include <windows.h>
+
+#define VER_FILEVERSION @PROJECT_VERSION_MAJOR@,@PROJECT_VERSION_MINOR@,@PROJECT_VERSION_PATCH@,0
+#define VER_FILEVERSION_STR "@PROJECT_VERSION_MAJOR@.@PROJECT_VERSION_MINOR@.@PROJECT_VERSION_PATCH@\0"
+
+#define VER_PRODUCTVERSION @PROJECT_VERSION_MAJOR@,@PROJECT_VERSION_MINOR@,@PROJECT_VERSION_PATCH@,0
+#define VER_PRODUCTVERSION_STR "@PROJECT_VERSION_MAJOR@.@PROJECT_VERSION_MINOR@.@PROJECT_VERSION_PATCH@\0"
+
+#ifndef DEBUG
+#define VER_DEBUG 0
+#else
+#define VER_DEBUG VS_FF_DEBUG
+#endif
+
+VS_VERSION_INFO VERSIONINFO
+FILEVERSION VER_FILEVERSION
+PRODUCTVERSION VER_PRODUCTVERSION
+FILEFLAGSMASK VS_FFI_FILEFLAGSMASK
+FILEFLAGS VER_DEBUG
+FILEOS VOS__WINDOWS32
+FILETYPE VFT_APP
+BEGIN
+ BLOCK "StringFileInfo"
+ BEGIN
+ BLOCK "0409FDE9"
+ BEGIN
+ VALUE "LegalCopyright", "Apache License v2.0"
+ VALUE "CompanyName", "Apache Software Foundation"
+ VALUE "ProductName", "MiNiFi C++"
Review Comment:
I think we should make it possible to override the branding info as well from cmake, to make it easier to repackage and redistribute the software.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1417: MINIFICPP-1834 Add VERSIONINFO resource file
Posted by GitBox <gi...@apache.org>.
fgerlits commented on code in PR #1417:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1417#discussion_r978522773
##########
versioninfo.rc.in:
##########
@@ -0,0 +1,44 @@
+#include <windows.h>
+
+#define VER_FILEVERSION @PROJECT_VERSION_MAJOR@,@PROJECT_VERSION_MINOR@,@PROJECT_VERSION_PATCH@,0
+#define VER_FILEVERSION_STR "@PROJECT_VERSION_MAJOR@.@PROJECT_VERSION_MINOR@.@PROJECT_VERSION_PATCH@\0"
+
+#define VER_PRODUCTVERSION @PROJECT_VERSION_MAJOR@,@PROJECT_VERSION_MINOR@,@PROJECT_VERSION_PATCH@,0
+#define VER_PRODUCTVERSION_STR "@PROJECT_VERSION_MAJOR@.@PROJECT_VERSION_MINOR@.@PROJECT_VERSION_PATCH@\0"
+
+#ifndef DEBUG
+#define VER_DEBUG 0
+#else
+#define VER_DEBUG VS_FF_DEBUG
+#endif
+
+VS_VERSION_INFO VERSIONINFO
+FILEVERSION VER_FILEVERSION
+PRODUCTVERSION VER_PRODUCTVERSION
+FILEFLAGSMASK VS_FFI_FILEFLAGSMASK
+FILEFLAGS VER_DEBUG
+FILEOS VOS__WINDOWS32
+FILETYPE VFT_APP
+BEGIN
+ BLOCK "StringFileInfo"
+ BEGIN
+ BLOCK "0409FDE9"
+ BEGIN
+ VALUE "LegalCopyright", "Apache License v2.0"
+ VALUE "CompanyName", "Apache Software Foundation"
+ VALUE "ProductName", "MiNiFi C++"
Review Comment:
fixed in b2598b784de173952a58c0a8c79377bc08412b43 and 4c7a5c317b598b4a459f7ffc271785f00cbd3dc2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org