You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Ke Jia <ke...@intel.com> on 2016/05/20 02:22:54 UTC

Review Request 47628: SENTRY-1274: Enable ALTERVIEW_AS in hive binding

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47628/
-----------------------------------------------------------

Review request for sentry, Colin Ma and Dapeng Sun.


Repository: sentry


Description
-------

Enable ALTERVIEW_AS in hive binding.


Diffs
-----

  sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java ac8265f 
  sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java bc158ff 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperationsPart1.java 0522ba0 

Diff: https://reviews.apache.org/r/47628/diff/


Testing
-------

all tests passed


Thanks,

Ke Jia


Re: Review Request 47628: SENTRY-1274: Enable ALTERVIEW_AS in hive binding

Posted by Dapeng Sun <da...@intel.com>.

> On \u4e94\u6708 20, 2016, 10:35 a.m., Dapeng Sun wrote:
> > Ship It!

LGTM, better to fill the field "Bugs" with jira id likes "SENTRY-1274" next time.


- Dapeng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47628/#review134081
-----------------------------------------------------------


On \u4e94\u6708 20, 2016, 10:22 a.m., Ke Jia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47628/
> -----------------------------------------------------------
> 
> (Updated \u4e94\u6708 20, 2016, 10:22 a.m.)
> 
> 
> Review request for sentry, Colin Ma and Dapeng Sun.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Enable ALTERVIEW_AS in hive binding.
> 
> 
> Diffs
> -----
> 
>   sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java ac8265f 
>   sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java bc158ff 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperationsPart1.java 0522ba0 
> 
> Diff: https://reviews.apache.org/r/47628/diff/
> 
> 
> Testing
> -------
> 
> all tests passed
> 
> 
> Thanks,
> 
> Ke Jia
> 
>


Re: Review Request 47628: SENTRY-1274: Enable ALTERVIEW_AS in hive binding

Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47628/#review134081
-----------------------------------------------------------


Ship it!




Ship It!

- Dapeng Sun


On \u4e94\u6708 20, 2016, 10:22 a.m., Ke Jia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47628/
> -----------------------------------------------------------
> 
> (Updated \u4e94\u6708 20, 2016, 10:22 a.m.)
> 
> 
> Review request for sentry, Colin Ma and Dapeng Sun.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Enable ALTERVIEW_AS in hive binding.
> 
> 
> Diffs
> -----
> 
>   sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java ac8265f 
>   sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java bc158ff 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperationsPart1.java 0522ba0 
> 
> Diff: https://reviews.apache.org/r/47628/diff/
> 
> 
> Testing
> -------
> 
> all tests passed
> 
> 
> Thanks,
> 
> Ke Jia
> 
>