You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/14 19:11:51 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4823: Enhance
RoutingTable with ServerInstance
codecov-io commented on issue #4823: Enhance RoutingTable with ServerInstance
URL: https://github.com/apache/incubator-pinot/pull/4823#issuecomment-554035393
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4823?src=pr&el=h1) Report
> Merging [#4823](https://codecov.io/gh/apache/incubator-pinot/pull/4823?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/2e221e64cc9c511672844d71574c3cc919654f5d?src=pr&el=desc) will **increase** coverage by `0.16%`.
> The diff coverage is `88.96%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4823/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4823?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4823 +/- ##
============================================
+ Coverage 57.6% 57.77% +0.16%
Complexity 4 4
============================================
Files 1213 1213
Lines 65598 65608 +10
Branches 9553 9553
============================================
+ Hits 37790 37903 +113
+ Misses 24941 24830 -111
- Partials 2867 2875 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4823?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ing/builder/DefaultOfflineRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4823/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9idWlsZGVyL0RlZmF1bHRPZmZsaW5lUm91dGluZ1RhYmxlQnVpbGRlci5qYXZh) | `47.05% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ng/builder/DefaultRealtimeRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4823/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9idWlsZGVyL0RlZmF1bHRSZWFsdGltZVJvdXRpbmdUYWJsZUJ1aWxkZXIuamF2YQ==) | `61.9% <ø> (-4.77%)` | `0 <0> (ø)` | |
| [...rg/apache/pinot/core/transport/ServerResponse.java](https://codecov.io/gh/apache/incubator-pinot/pull/4823/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvU2VydmVyUmVzcG9uc2UuamF2YQ==) | `90.47% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/pinot/core/transport/QueryRouter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4823/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvUXVlcnlSb3V0ZXIuamF2YQ==) | `93.22% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...rg/apache/pinot/core/transport/ServerChannels.java](https://codecov.io/gh/apache/incubator-pinot/pull/4823/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvU2VydmVyQ2hhbm5lbHMuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...esthandler/ConnectionPoolBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4823/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQ29ubmVjdGlvblBvb2xCcm9rZXJSZXF1ZXN0SGFuZGxlci5qYXZh) | `88.82% <100%> (+0.62%)` | `0 <0> (ø)` | :arrow_down: |
| [...core/query/selection/SelectionOperatorService.java](https://codecov.io/gh/apache/incubator-pinot/pull/4823/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vU2VsZWN0aW9uT3BlcmF0b3JTZXJ2aWNlLmphdmE=) | `98.11% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...thandler/SingleConnectionBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4823/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvU2luZ2xlQ29ubmVjdGlvbkJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `87.8% <100%> (+3.71%)` | `0 <0> (ø)` | :arrow_down: |
| [...ing/builder/GeneratorBasedRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4823/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9idWlsZGVyL0dlbmVyYXRvckJhc2VkUm91dGluZ1RhYmxlQnVpbGRlci5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...t/core/query/selection/SelectionOperatorUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4823/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vU2VsZWN0aW9uT3BlcmF0b3JVdGlscy5qYXZh) | `95.76% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [56 more](https://codecov.io/gh/apache/incubator-pinot/pull/4823/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4823?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4823?src=pr&el=footer). Last update [2e221e6...4e61078](https://codecov.io/gh/apache/incubator-pinot/pull/4823?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org