You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by Doug Claar <do...@claar.org> on 2011/04/19 02:51:44 UTC

commit-email.pl violates rfc2822

rfc2822 section 2.1.1 specifies that "Each line of characters MUST be no more 
than 998 characters...excluding the CRLF." (http://www.faqs.org/rfcs/rfc2822.html)

commit-email.pl has no mechanism to check/enforce that; thus, a large checkin 
of many directories will create an email message that violates the rfc. I 
could not find an existing bug for this problem.

Doug


Re: commit-email.pl violates rfc2822

Posted by Ryan Schmidt <su...@ryandesign.com>.
On Apr 18, 2011, at 19:51, Doug Claar wrote:

> rfc2822 section 2.1.1 specifies that “Each line of characters MUST be no more than 998 characters…excluding the CRLF.” (http://www.faqs.org/rfcs/rfc2822.html)
> 
> commit-email.pl has no mechanism to check/enforce that; thus, a large checkin of many directories will create an email message that violates the rfc. I could not find an existing bug for this problem.

That's probably because commit-email.pl has been deprecated for years, meaning you're not supposed to be using it anymore. See the comment header:

http://svn.apache.org/repos/asf/subversion/trunk/contrib/hook-scripts/commit-email.pl.in

# ====================================================================
# This script is deprecated.  The Subversion developers recommend
# using mailer.py for post-commit and post-revprop change
# notifications.  If you wish to improve or add features to a
# post-commit notification script, please do that work on mailer.py.
# See http://svn.apache.org/repos/asf/subversion/trunk/tools/hook-scripts/mailer .
# ====================================================================