You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "weiting-chen (via GitHub)" <gi...@apache.org> on 2024/08/19 05:51:36 UTC
[PR] [Gluten-6915][CORE] Fix listComments TypeError [incubator-gluten]
weiting-chen opened a new pull request, #6919:
URL: https://github.com/apache/incubator-gluten/pull/6919
## What changes were proposed in this pull request?
Fix github action script v7's listComments TypeError issue
## How was this patch tested?
n/a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6915][CORE]Fix listComments TypeError [incubator-gluten]
Posted by "weiting-chen (via GitHub)" <gi...@apache.org>.
weiting-chen merged PR #6919:
URL: https://github.com/apache/incubator-gluten/pull/6919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [Gluten-6915][CORE] Fix listComments TypeError [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on PR #6919:
URL: https://github.com/apache/incubator-gluten/pull/6919#issuecomment-2295742087
```
TypeError: Cannot read properties of undefined (reading 'listComments')
```
Seems `listComments` is not available after the upgrading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6915][CORE]Fix listComments TypeError [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #6919:
URL: https://github.com/apache/incubator-gluten/pull/6919#issuecomment-2297184858
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_master_08_19_2024_time.csv</font></td>
<td><font color=#000000>log/native_master_08_18_2024_9fcd4885c7_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#F92663>q1</font></td>
<td><font color=#F92663>39.36</font></td>
<td><font color=#F92663>40.01</font></td>
<td><font color=#F92663>0.644</font></td>
<td><font color=#F92663>101.64%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q2</font></td>
<td><font color=#6F9915>30.00</font></td>
<td><font color=#6F9915>28.03</font></td>
<td><font color=#6F9915>-1.972</font></td>
<td><font color=#6F9915>93.43%</font></td>
</tr>
<tr>
<td><font color=#F92663>q3</font></td>
<td><font color=#F92663>53.30</font></td>
<td><font color=#F92663>53.67</font></td>
<td><font color=#F92663>0.379</font></td>
<td><font color=#F92663>100.71%</font></td>
</tr>
<tr>
<td><font color=#F92663>q4</font></td>
<td><font color=#F92663>42.63</font></td>
<td><font color=#F92663>42.78</font></td>
<td><font color=#F92663>0.149</font></td>
<td><font color=#F92663>100.35%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q5</font></td>
<td><font color=#6F9915>104.83</font></td>
<td><font color=#6F9915>104.21</font></td>
<td><font color=#6F9915>-0.627</font></td>
<td><font color=#6F9915>99.40%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q6</font></td>
<td><font color=#6F9915>12.68</font></td>
<td><font color=#6F9915>11.23</font></td>
<td><font color=#6F9915>-1.447</font></td>
<td><font color=#6F9915>88.59%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q7</font></td>
<td><font color=#6F9915>117.27</font></td>
<td><font color=#6F9915>115.52</font></td>
<td><font color=#6F9915>-1.749</font></td>
<td><font color=#6F9915>98.51%</font></td>
</tr>
<tr>
<td><font color=#F92663>q8</font></td>
<td><font color=#F92663>115.19</font></td>
<td><font color=#F92663>116.72</font></td>
<td><font color=#F92663>1.525</font></td>
<td><font color=#F92663>101.32%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q9</font></td>
<td><font color=#6F9915>169.64</font></td>
<td><font color=#6F9915>168.24</font></td>
<td><font color=#6F9915>-1.398</font></td>
<td><font color=#6F9915>99.18%</font></td>
</tr>
<tr>
<td><font color=#F92663>q10</font></td>
<td><font color=#F92663>64.81</font></td>
<td><font color=#F92663>66.68</font></td>
<td><font color=#F92663>1.868</font></td>
<td><font color=#F92663>102.88%</font></td>
</tr>
<tr>
<td><font color=#F92663>q11</font></td>
<td><font color=#F92663>26.35</font></td>
<td><font color=#F92663>30.17</font></td>
<td><font color=#F92663>3.818</font></td>
<td><font color=#F92663>114.49%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q12</font></td>
<td><font color=#6F9915>32.85</font></td>
<td><font color=#6F9915>31.20</font></td>
<td><font color=#6F9915>-1.644</font></td>
<td><font color=#6F9915>95.00%</font></td>
</tr>
<tr>
<td><font color=#F92663>q13</font></td>
<td><font color=#F92663>51.31</font></td>
<td><font color=#F92663>51.65</font></td>
<td><font color=#F92663>0.339</font></td>
<td><font color=#F92663>100.66%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q14</font></td>
<td><font color=#6F9915>27.14</font></td>
<td><font color=#6F9915>26.30</font></td>
<td><font color=#6F9915>-0.839</font></td>
<td><font color=#6F9915>96.91%</font></td>
</tr>
<tr>
<td><font color=#F92663>q15</font></td>
<td><font color=#F92663>54.69</font></td>
<td><font color=#F92663>54.84</font></td>
<td><font color=#F92663>0.152</font></td>
<td><font color=#F92663>100.28%</font></td>
</tr>
<tr>
<td><font color=#F92663>q16</font></td>
<td><font color=#F92663>17.77</font></td>
<td><font color=#F92663>19.79</font></td>
<td><font color=#F92663>2.015</font></td>
<td><font color=#F92663>111.34%</font></td>
</tr>
<tr>
<td><font color=#F92663>q17</font></td>
<td><font color=#F92663>130.71</font></td>
<td><font color=#F92663>131.24</font></td>
<td><font color=#F92663>0.539</font></td>
<td><font color=#F92663>100.41%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q18</font></td>
<td><font color=#6F9915>197.75</font></td>
<td><font color=#6F9915>197.27</font></td>
<td><font color=#6F9915>-0.473</font></td>
<td><font color=#6F9915>99.76%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q19</font></td>
<td><font color=#6F9915>30.51</font></td>
<td><font color=#6F9915>25.90</font></td>
<td><font color=#6F9915>-4.606</font></td>
<td><font color=#6F9915>84.90%</font></td>
</tr>
<tr>
<td><font color=#F92663>q20</font></td>
<td><font color=#F92663>39.19</font></td>
<td><font color=#F92663>40.46</font></td>
<td><font color=#F92663>1.274</font></td>
<td><font color=#F92663>103.25%</font></td>
</tr>
<tr>
<td><font color=#F92663>q21</font></td>
<td><font color=#F92663>384.57</font></td>
<td><font color=#F92663>386.69</font></td>
<td><font color=#F92663>2.121</font></td>
<td><font color=#F92663>100.55%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q22</font></td>
<td><font color=#6F9915>15.48</font></td>
<td><font color=#6F9915>15.31</font></td>
<td><font color=#6F9915>-0.166</font></td>
<td><font color=#6F9915>98.93%</font></td>
</tr>
<tr>
<td><font color=#6F9915>total</font></td>
<td><font color=#6F9915>1758.03</font></td>
<td><font color=#6F9915>1757.93</font></td>
<td><font color=#6F9915>-0.098</font></td>
<td><font color=#6F9915>99.99%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org