[jira] [Commented] (PHOENIX-2830) Upgrade code fails when upgrading from a version before 4.3

["James Taylor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-2830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235848#comment-15235848 ] 

James Taylor commented on PHOENIX-2830:
---------------------------------------

Patch looks fine, but one byproduct if there's an unexpected time stamp for SYSTEM.CATALOG is that there will be more columns in the same ALTER TABLE call. In this case, if *any* of the columns exist, none of the ones listed would be added. Safer would be to have individual calls for each column being added. That way if for some unknown reason the columns were added but the time stamp didn't advance, any missing columns would be added.

> Upgrade code fails when upgrading from a version before 4.3
> -----------------------------------------------------------
>
>                 Key: PHOENIX-2830
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2830
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-2830.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)