You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "michael-hoke (via GitHub)" <gi...@apache.org> on 2023/04/27 16:04:16 UTC
[GitHub] [daffodil-vscode] michael-hoke opened a new issue, #595: Create language support for TDML
michael-hoke opened a new issue, #595:
URL: https://github.com/apache/daffodil-vscode/issues/595
We should be able to open a TDML file and have the language identified as TDML. We should then be able to move TDML items from the command palette that are locked to the DFDL language into the new TDML language.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] michael-hoke commented on issue #595: Create GUI editor for TDML files
Posted by "michael-hoke (via GitHub)" <gi...@apache.org>.
michael-hoke commented on issue #595:
URL: https://github.com/apache/daffodil-vscode/issues/595#issuecomment-1721645060
If time permits, explore the possibility of using the Selenium tests for the new GUI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] michael-hoke commented on issue #595: Create GUI editor for TDML files
Posted by "michael-hoke (via GitHub)" <gi...@apache.org>.
michael-hoke commented on issue #595:
URL: https://github.com/apache/daffodil-vscode/issues/595#issuecomment-1710412031
Previously 'Create Language Support for TDML' - the intent is still the same where we need to create file-type identification for TDML, but we will be supplying a GUI front-end for the TDML file instead of supplying all functionality only through commands.
We can determine during the implementation process if it's worth including the functionality through commands as well as providing a "raw" interface to the TDML file (hidden behind the GUI).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Create GUI editor for TDML files [daffodil-vscode]
Posted by "NolanMatt (via GitHub)" <gi...@apache.org>.
NolanMatt commented on issue #595:
URL: https://github.com/apache/daffodil-vscode/issues/595#issuecomment-1845794640
to add to what Mike said, if we remove all imports from our webview.js file, then it will function as expected, but obviously doesn't do anything because its just dispalying raw hardcoded html at that point since we can't do any xml manipulation without importing xml libraries.
This applies to any import that is not local to our code (ie we can import the tdmlXmlUtils file, but we cannot import anything from a library)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Create GUI editor for TDML files [daffodil-vscode]
Posted by "hdalsania (via GitHub)" <gi...@apache.org>.
hdalsania commented on issue #595:
URL: https://github.com/apache/daffodil-vscode/issues/595#issuecomment-2004261375
This feature is implemented and merged with #936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] michael-hoke commented on issue #595: Create language support for TDML
Posted by "michael-hoke (via GitHub)" <gi...@apache.org>.
michael-hoke commented on issue #595:
URL: https://github.com/apache/daffodil-vscode/issues/595#issuecomment-1544702136
See here for some naming suggestions to keep in mind when rebuilding TDML support. Also keep in mind that we are starting off implementing the bare minimum of the TDML spec, so we should try to avoid potentially conflicting names of potential future features.
https://github.com/apache/daffodil-vscode/pull/625#discussion_r1187619693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] michael-hoke commented on issue #595: Create language support for TDML
Posted by "michael-hoke (via GitHub)" <gi...@apache.org>.
michael-hoke commented on issue #595:
URL: https://github.com/apache/daffodil-vscode/issues/595#issuecomment-1581579951
- Add 'none' back in as an option for tdmlAction. Keep 'generate' as the default option.
- Is this right? Is there a scenario where turning off TDML generation makes sense? If there isn't, then leave 'none' out.
- Make tdmlConfig a mandatory part of the launch config
- Change the default location of the generated TDML file to be in /tmp (or OS alternative)
- Add a new command to copy the TDML file from /tmp to a user-defined location
- Remove the Generate TDML command from the command palette
- Create a new 'TDML' language that inherits from XML (should be set up similarly to dfdl language).
- Move Append TDML command to the new TDML language
- Add a command to create zip file in TDML language
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Create GUI editor for TDML files [daffodil-vscode]
Posted by "michael-hoke (via GitHub)" <gi...@apache.org>.
michael-hoke commented on issue #595:
URL: https://github.com/apache/daffodil-vscode/issues/595#issuecomment-1845772725
Current issue that we are running into is that when we try to use HTML to render a GUI, we are unable to import anything from the WebView we are using to produce the HTML. Our best guess at the moment is that whatever is responsible for packaging up dependencies to be used dynamically during runtime is not doing it correctly. Second best guess is that we are importing using the wrong path, but the files we are pointing to exist on disk in the location we expect them to exist (might be related to index.d.ts or .jms missing when expected).
We used a guide (https://timheuer.com/blog/resx-editor-for-visual-studio-code/) to base our initial version of a WebView on, but that wasn't working due to the import issue. We tried using that extension (https://marketplace.visualstudio.com/items?itemName=TimHeuer.resx-editor) and it works fine. However, when we try to use the same methods in the DFDL extension, it does not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Create GUI editor for TDML files [daffodil-vscode]
Posted by "hdalsania (via GitHub)" <gi...@apache.org>.
hdalsania closed issue #595: Create GUI editor for TDML files
URL: https://github.com/apache/daffodil-vscode/issues/595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org