You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/03 08:54:05 UTC
[GitHub] [dubbo-go-samples] Mulavar opened a new pull request #156: add tracing integration test
Mulavar opened a new pull request #156:
URL: https://github.com/apache/dubbo-go-samples/pull/156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #156: add tracing integration test
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #156:
URL: https://github.com/apache/dubbo-go-samples/pull/156#discussion_r663421382
##########
File path: tracing/dubbo/go-client/cmd/client.go
##########
@@ -20,6 +20,7 @@ package main
import (
"context"
"fmt"
+ "github.com/apache/dubbo-go-samples/tracing/dubbo/go-client/pkg"
Review comment:
hey, guy, pls concern ur import block before submit ur pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin merged pull request #156: add tracing integration test
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin merged pull request #156:
URL: https://github.com/apache/dubbo-go-samples/pull/156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #156: add tracing integration test
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #156:
URL: https://github.com/apache/dubbo-go-samples/pull/156#discussion_r663421486
##########
File path: tracing/dubbo/go-client/cmd/client.go
##########
@@ -50,19 +51,25 @@ import (
)
var (
+ userProvider = new(pkg.UserProvider)
Review comment:
In go, it is not a good program habit to use the keyword `new`. Use the `&pkg.UserProvider{}` instead pls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org