Re: Review Request 74341: ATLAS-4733 : Download Basic and DSL search results

[Jayendra Parab <ja...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74341/#review225358
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
Lines 491 (patched)
<https://reviews.apache.org/r/74341/#comment314006>

    Consider having a constructor to create AtlasSearchDownloadRecord with the values set here and also in the for-loop below.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/searchdownload/SearchResultDownloadTask.java
Lines 71 (patched)
<https://reviews.apache.org/r/74341/#comment314008>

    Consider prefixing all the download search related properties with atlas.download.search, so that the the properties aren't confused with any other search related properties.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/searchdownload/SearchResultDownloadTask.java
Lines 72 (patched)
<https://reviews.apache.org/r/74341/#comment314007>

    Consider using sub-dir inside atlas.home directory as the default directory path.
    "/tmp" path is accessible for all users.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/searchdownload/SearchResultDownloadTaskFactory.java
Lines 55 (patched)
<https://reviews.apache.org/r/74341/#comment314010>

    Consider having only the expiry time property, not the property for cleanup



repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java
Lines 108 (patched)
<https://reviews.apache.org/r/74341/#comment314009>

    Is graph.commit() required for a read-only operation?


- Jayendra Parab


On March 30, 2023, 2:37 p.m., Mandar Ambawane wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74341/
> -----------------------------------------------------------
> 
> (Updated March 30, 2023, 2:37 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Pinal Shah, Radhika Kundam, Sheetal Shah, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4733
>     https://issues.apache.org/jira/browse/ATLAS-4733
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This ticket tracks the Server side changes required for the Search result download task.
> 
> From server side, each download request is considered as a separate thread which will run in the background and will generate the csv file according to the inputs provided.
> 
> The generated files will be stored in the specific location (which is configurable).
> 
> A scheduler will be run to delete the old files. In this case, the scheduler interval and file expiry time is also configurable.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 608342433 
>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResultDownloadStatus.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java d94110004 
>   repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 582d97542 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/searchdownload/SearchResultDownloadTask.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/searchdownload/SearchResultDownloadTaskFactory.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/tasks/TaskManagement.java 5b4bf71cc 
>   repository/src/main/java/org/apache/atlas/tasks/TaskRegistry.java 6f770edb1 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java a6ca04f3c 
> 
> 
> Diff: https://reviews.apache.org/r/74341/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>