You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2016/10/25 23:21:35 UTC

Review Request 53176: RANGER-1191: Added code to retry usersync update to ranger admin if the previous update fails

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53176/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-1191
    https://issues.apache.org/jira/browse/RANGER-1191


Repository: ranger


Description
-------

Added code to save the state if ranger admin update fail or success. During every sync interval for Unix or file based sync, in order to perform sync process, added extra check to perform sync process if the previous update to ranger admin has failed.


Diffs
-----

  ugsync/src/main/java/org/apache/ranger/unixusersync/process/FileSourceUserGroupBuilder.java 298941a 
  ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 296d94f 
  ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java 88aa266 
  ugsync/src/main/java/org/apache/ranger/usergroupsync/UserGroupSink.java 6cce36f 

Diff: https://reviews.apache.org/r/53176/diff/


Testing
-------

1. Performed functional tests with unix and file based sync by stopping Ranger admin and adding new users to the sync source.
2. Performed regression tests for regular use cases.
3. Performed functional test with ranger admin down during initial usersync startup process.


Thanks,

Sailaja Polavarapu


Re: Review Request 53176: RANGER-1191: Added code to retry usersync update to ranger admin if the previous update fails

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53176/#review153869
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Oct. 25, 2016, 11:21 p.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53176/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2016, 11:21 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1191
>     https://issues.apache.org/jira/browse/RANGER-1191
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Added code to save the state if ranger admin update fail or success. During every sync interval for Unix or file based sync, in order to perform sync process, added extra check to perform sync process if the previous update to ranger admin has failed.
> 
> 
> Diffs
> -----
> 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/process/FileSourceUserGroupBuilder.java 298941a 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 296d94f 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java 88aa266 
>   ugsync/src/main/java/org/apache/ranger/usergroupsync/UserGroupSink.java 6cce36f 
> 
> Diff: https://reviews.apache.org/r/53176/diff/
> 
> 
> Testing
> -------
> 
> 1. Performed functional tests with unix and file based sync by stopping Ranger admin and adding new users to the sync source.
> 2. Performed regression tests for regular use cases.
> 3. Performed functional test with ranger admin down during initial usersync startup process.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>