You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/02/18 13:31:26 UTC
[GitHub] [knox] smolnar82 opened a new pull request #265: KNOX-2161 - CM
generated descriptors are read-only on Admin UI
smolnar82 opened a new pull request #265: KNOX-2161 - CM generated descriptors are read-only on Admin UI
URL: https://github.com/apache/knox/pull/265
## What changes were proposed in this pull request?
#236 introduces a new descriptor type (using on Hadoop XML structure). Descriptors generated out of those XML configurations are read-only on Admin UI from now on.
## How was this patch tested?
Updated and executed JUnit tests.
Additionally, the following manual test steps were executed:
1. built and deployed Knox with my changes
2. logged into Admin UI
3. created a descriptor called `testDescriptor` on Admin UI
4. placed the following CM-type descriptor in Knox's descriptor directory:
```
<configuration>
<property>
<name>topology1</name>
<value>
providerConfigRef=default-providers;
app:knoxauth:param1.name=param1.value;
HIVE:url=http://localhost:456;
HIVE:version=1.0;
HIVE:httpclient.connectionTimeout=5m;
HIVE:httpclient.socketTimeout=100m
</value>
</property>
<property>
<name>topology2</name>
<value>
providerConfigRef=default-providers;
HDFS:url=http://localhost:456;
HDFS:httpclient.connectionTimeout=5m;
HDFS:httpclient.socketTimeout=100m
</value>
</property>
</configuration>
```
5. confirmed that:
`testDescriptor` is not read-only; it can be updated/removed
`topology1` and `topology2` descriptors are read-only: they cannot be removed/updted (no icons displayed)
<img width="1666" alt="Screen Shot 2020-02-18 at 2 25 29 PM" src="https://user-images.githubusercontent.com/34065904/74740505-49178080-525b-11ea-9bd8-becb55624d37.png">
<img width="1668" alt="Screen Shot 2020-02-18 at 2 25 45 PM" src="https://user-images.githubusercontent.com/34065904/74740511-4c127100-525b-11ea-93aa-505761ec16c8.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] smolnar82 merged pull request #265: KNOX-2161 - CM generated
descriptors are read-only on Admin UI
Posted by GitBox <gi...@apache.org>.
smolnar82 merged pull request #265: KNOX-2161 - CM generated descriptors are read-only on Admin UI
URL: https://github.com/apache/knox/pull/265
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services