You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by jd...@apache.org on 2011/04/15 00:10:53 UTC

svn commit: r1092532 - in /hbase/trunk/src/main: java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ruby/shell/commands/balancer.rb

Author: jdcryans
Date: Thu Apr 14 22:10:53 2011
New Revision: 1092532

URL: http://svn.apache.org/viewvc?rev=1092532&view=rev
Log:
Better balancer javadoc

Modified:
    hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
    hbase/trunk/src/main/ruby/shell/commands/balancer.rb

Modified: hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
URL: http://svn.apache.org/viewvc/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java?rev=1092532&r1=1092531&r2=1092532&view=diff
==============================================================================
--- hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java (original)
+++ hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java Thu Apr 14 22:10:53 2011
@@ -188,7 +188,9 @@ public interface HMasterInterface extend
    * Run the balancer.  Will run the balancer and if regions to move, it will
    * go ahead and do the reassignments.  Can NOT run for various reasons.  Check
    * logs.
-   * @return True if balancer ran, false otherwise.
+   * @return True if balancer ran and was able to tell the region servers to
+   * unassign all the regions to balance (the re-assignment itself is async),
+   * false otherwise.
    */
   public boolean balance();
 

Modified: hbase/trunk/src/main/ruby/shell/commands/balancer.rb
URL: http://svn.apache.org/viewvc/hbase/trunk/src/main/ruby/shell/commands/balancer.rb?rev=1092532&r1=1092531&r2=1092532&view=diff
==============================================================================
--- hbase/trunk/src/main/ruby/shell/commands/balancer.rb (original)
+++ hbase/trunk/src/main/ruby/shell/commands/balancer.rb Thu Apr 14 22:10:53 2011
@@ -23,8 +23,9 @@ module Shell
     class Balancer < Command
       def help
         return <<-EOF
-Trigger the cluster balancer. Returns true if balancer ran.  Otherwise
-false (Will not run if regions in transition).
+Trigger the cluster balancer. Returns true if balancer ran and was able to
+tell the region servers to unassign all the regions to balance  (the re-assignment itself is async). 
+Otherwise false (Will not run if regions in transition).
 EOF
       end