You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by lresende <gi...@git.apache.org> on 2016/07/15 00:52:39 UTC
[GitHub] zeppelin pull request #1186: [ZEPPELIN-1179] Append scala version to maven a...
GitHub user lresende opened a pull request:
https://github.com/apache/zeppelin/pull/1186
[ZEPPELIN-1179] Append scala version to maven artifacts
### What is this PR for?
Now that we have support for both Scala 2.10 and 2.11 we need to append Scala version to the maven artifact id in order to properly publish artifacts for both Scala releases.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-1179](https://issues.apache.org/jira/browse/ZEPPELIN-1179)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lresende/incubator-zeppelin scala-version
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1186.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1186
----
commit f6da160b7b323d74703b41b498c82036c107b55f
Author: Luciano Resende <lr...@apache.org>
Date: 2016-07-15T00:18:53Z
[ZEPPELIN-1179] Append scala version to maven artifacts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1186: [ZEPPELIN-1179] Append scala version to maven a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1186
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1186: [ZEPPELIN-1179] Append scala version to maven artifact...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1186
I have one question before merging, is there any special reason that ignite doesn't have `_2.11` suffix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1186: [ZEPPELIN-1179] Append scala version to maven artifact...
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1186
This assumes that #747 is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1186: [ZEPPELIN-1179] Append scala version to maven artifact...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1186
CI failures seems irrelevant. LGTM merging if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1186: [ZEPPELIN-1179] Append scala version to maven artifact...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/zeppelin/pull/1186
Looks good to me. Merge if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1186: [ZEPPELIN-1179] Append scala version to maven artifact...
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1186
@minahlee I have included the missing modules, and also updated the build to change the artifact version to _2.11 when performing the build based on Scala 2.11.
The build is still failing with the 10 minutes issue and other issue that seems not related.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1186: [ZEPPELIN-1179] Append scala version to maven artifact...
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1186
@minahlee Good catch, let me fix that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---