You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2017/01/15 21:35:58 UTC

Review Request 55550: Windows: Enabled health checker tests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55550/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.


Bugs: MESOS-6709
    https://issues.apache.org/jira/browse/MESOS-6709


Repository: mesos


Description
-------

Windows: Enabled health checker tests.


Diffs
-----

  src/tests/health_check_tests.cpp 0a6d2dd295408dcc0434f3573e307e685f9abfe4 

Diff: https://reviews.apache.org/r/55550/diff/


Testing
-------


Thanks,

Alex Clemmer

Re: Review Request 55550: Windows: Enabled health checker tests.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55550/#review163172
-----------------------------------------------------------


Ship it!




Just a few minor things that I can tweak before committing.


src/tests/health_check_tests.cpp (lines 705 - 714)
<https://reviews.apache.org/r/55550/#comment234604>

    No need to duplicate this comment.



src/tests/health_check_tests.cpp (lines 1167 - 1169)
<https://reviews.apache.org/r/55550/#comment234611>

    Whitespace can be removed here.



src/tests/health_check_tests.cpp (lines 1199 - 1208)
<https://reviews.apache.org/r/55550/#comment234603>

    Same here.


- Joseph Wu


On Jan. 15, 2017, 1:35 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55550/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2017, 1:35 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
> 
> 
> Bugs: MESOS-6709
>     https://issues.apache.org/jira/browse/MESOS-6709
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Enabled health checker tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/health_check_tests.cpp 0a6d2dd295408dcc0434f3573e307e685f9abfe4 
> 
> Diff: https://reviews.apache.org/r/55550/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>