You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "John Gordon (JIRA)" <ji...@apache.org> on 2012/07/07 02:35:33 UTC
[jira] [Created] (PIG-2797) Tests should not create their own file
URIs through string concatenation, should use Util.generateURI instead
John Gordon created PIG-2797:
--------------------------------
Summary: Tests should not create their own file URIs through string concatenation, should use Util.generateURI instead
Key: PIG-2797
URL: https://issues.apache.org/jira/browse/PIG-2797
Project: Pig
Issue Type: Sub-task
Reporter: John Gordon
A number of pig tests create URIs via string concatenation when they are trying to load files with something like:
commandString = "load file:" + fileName + " using "...
This should just use the Util method generateURI to create the URI correctly in a cross-platform context.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2797) Tests should not create their own file
URIs through string concatenation, should use Util.generateURI instead
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-2797:
----------------------------
Fix Version/s: 0.10.1
Further commit to 0.10 branch.
> Tests should not create their own file URIs through string concatenation, should use Util.generateURI instead
> -------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2797
> URL: https://issues.apache.org/jira/browse/PIG-2797
> Project: Pig
> Issue Type: Sub-task
> Reporter: John Gordon
> Fix For: 0.11, 0.10.1
>
> Attachments: trunkURIPatch.patch
>
>
> A number of pig tests create URIs via string concatenation when they are trying to load files with something like:
> commandString = "load file:" + fileName + " using "...
> This should just use the Util method generateURI to create the URI correctly in a cross-platform context.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2797) Tests should not create their own file
URIs through string concatenation, should use Util.generateURI instead
Posted by "John Gordon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Gordon updated PIG-2797:
-----------------------------
Attachment: trunkURIPatch.patch
refactoring tests that generate their own URI paths via string concatenation to use Util.generateURI. This also uses Util.encodeEscapes in cases where the text is to be executed in a pig script context (almost all) and so '\' is treated as an escape character.
> Tests should not create their own file URIs through string concatenation, should use Util.generateURI instead
> -------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2797
> URL: https://issues.apache.org/jira/browse/PIG-2797
> Project: Pig
> Issue Type: Sub-task
> Reporter: John Gordon
> Attachments: trunkURIPatch.patch
>
>
> A number of pig tests create URIs via string concatenation when they are trying to load files with something like:
> commandString = "load file:" + fileName + " using "...
> This should just use the Util method generateURI to create the URI correctly in a cross-platform context.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIG-2797) Tests should not create their own file
URIs through string concatenation, should use Util.generateURI instead
Posted by "Gianmarco De Francisci Morales (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gianmarco De Francisci Morales resolved PIG-2797.
-------------------------------------------------
Resolution: Fixed
Fix Version/s: 0.11
+1
Passes tests locally, committed.
Thanks for the contribution, John!
> Tests should not create their own file URIs through string concatenation, should use Util.generateURI instead
> -------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2797
> URL: https://issues.apache.org/jira/browse/PIG-2797
> Project: Pig
> Issue Type: Sub-task
> Reporter: John Gordon
> Fix For: 0.11
>
> Attachments: trunkURIPatch.patch
>
>
> A number of pig tests create URIs via string concatenation when they are trying to load files with something like:
> commandString = "load file:" + fileName + " using "...
> This should just use the Util method generateURI to create the URI correctly in a cross-platform context.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2797) Tests should not create their own
file URIs through string concatenation, should use Util.generateURI instead
Posted by "John Gordon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474801#comment-13474801 ]
John Gordon commented on PIG-2797:
----------------------------------
Thank you!
> Tests should not create their own file URIs through string concatenation, should use Util.generateURI instead
> -------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2797
> URL: https://issues.apache.org/jira/browse/PIG-2797
> Project: Pig
> Issue Type: Sub-task
> Reporter: John Gordon
> Fix For: 0.11
>
> Attachments: trunkURIPatch.patch
>
>
> A number of pig tests create URIs via string concatenation when they are trying to load files with something like:
> commandString = "load file:" + fileName + " using "...
> This should just use the Util method generateURI to create the URI correctly in a cross-platform context.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2797) Tests should not create their own file
URIs through string concatenation, should use Util.generateURI instead
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-2797:
----------------------------
Assignee: John Gordon
Hadoop Flags: Reviewed
> Tests should not create their own file URIs through string concatenation, should use Util.generateURI instead
> -------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2797
> URL: https://issues.apache.org/jira/browse/PIG-2797
> Project: Pig
> Issue Type: Sub-task
> Reporter: John Gordon
> Assignee: John Gordon
> Fix For: 0.11, 0.10.1
>
> Attachments: trunkURIPatch.patch
>
>
> A number of pig tests create URIs via string concatenation when they are trying to load files with something like:
> commandString = "load file:" + fileName + " using "...
> This should just use the Util method generateURI to create the URI correctly in a cross-platform context.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira