You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/20 20:21:14 UTC
[GitHub] [tvm] argrento opened a new pull request, #10867: Update gradle version in android apps
argrento opened a new pull request, #10867:
URL: https://github.com/apache/tvm/pull/10867
Update gradle configs to remove errors described in https://discuss.tvm.apache.org/t/gradle-build-fail-for-android-rpc-demo/10493
Modified:
* https://github.com/apache/tvm/tree/main/apps/android_camera
* https://github.com/apache/tvm/tree/main/apps/android_deploy
* https://github.com/apache/tvm/tree/main/apps/android_rpc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #10867: Update gradle version in android apps
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on PR #10867:
URL: https://github.com/apache/tvm/pull/10867#issuecomment-1093407341
@Lyken17 would love to ask you to try out and review this PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] TejashShah commented on pull request #10867: Update gradle version and other changes in android apps
Posted by GitBox <gi...@apache.org>.
TejashShah commented on PR #10867:
URL: https://github.com/apache/tvm/pull/10867#issuecomment-1105402229
Thanks @argrento for getting the CI passed.
@Lyken17 Please give it a try and review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #10867: Update gradle version in android apps
Posted by GitBox <gi...@apache.org>.
areusch commented on PR #10867:
URL: https://github.com/apache/tvm/pull/10867#issuecomment-1093354211
I'm not super-knowledgeable about Android stuff, but hopefully someone who is could review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] TejashShah commented on pull request #10867: Update gradle version and other changes in android apps
Posted by GitBox <gi...@apache.org>.
TejashShah commented on PR #10867:
URL: https://github.com/apache/tvm/pull/10867#issuecomment-1125193288
@Lyken17 We raised another PR https://github.com/apache/tvm/pull/11241 and please review and give your blessing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] argrento closed pull request #10867: Update gradle version and other changes in android apps
Posted by GitBox <gi...@apache.org>.
argrento closed pull request #10867: Update gradle version and other changes in android apps
URL: https://github.com/apache/tvm/pull/10867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] TejashShah commented on pull request #10867: Update gradle version in android apps
Posted by GitBox <gi...@apache.org>.
TejashShah commented on PR #10867:
URL: https://github.com/apache/tvm/pull/10867#issuecomment-1088904271
cc @masahi @areusch for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #10867: Update gradle version in android apps
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on PR #10867:
URL: https://github.com/apache/tvm/pull/10867#issuecomment-1089839489
Thanks for doing that! Also CC @Lyken17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lyken17 commented on pull request #10867: Update gradle version and other changes in android apps
Posted by GitBox <gi...@apache.org>.
Lyken17 commented on PR #10867:
URL: https://github.com/apache/tvm/pull/10867#issuecomment-1106712651
Sry for being late, was busy for some conference experiments.
I rarely code in Java so I am afraid that I cannot comment much on the modified code. But I have seen @argrento update `javah` command to `javac -h`. This was the cause of building error when using latest JDK https://discuss.tvm.apache.org/t/jvmpkg-fails-to-build-on-mac-osx/11578/2
In my build machine (Intel Mac Mini), JDK version 1.8.0_312, Clang 13.0.0, all three projects `android_camera`, `android_rpc`, `android_camera`, `android_deploy` can build successfully without error.
```
(base) ligeng@Lgs-Mac-mini➜ tvm2 git:(gradle-update) ✗ gh pr checkout 10867
(base) ligeng@Lgs-Mac-mini➜ tvm2 git:(gradle-update) ✗ java -version
openjdk version "1.8.0_312"
OpenJDK Runtime Environment (build 1.8.0_312-bre_2021_10_21_00_49-b00)
OpenJDK 64-Bit Server VM (build 25.312-b00, mixed mode)
(base) ligeng@Lgs-Mac-mini➜ tvm2 git:(gradle-update) ✗ clang --version
Homebrew clang version 13.0.0
Target: x86_64-apple-darwin19.6.0
Thread model: posix
InstalledDir: /usr/local/opt/llvm/bin
(base) ligeng@Lgs-Mac-mini➜ tvm2 git:(gradle-update) ✗ llvm-config --version
13.0.0
```
Due to my limited (human) bandwidth, I may be able to test 2~3 more JDK / NDK versions. Would it be possible to setup CI auto-build test for the three demos? @argrento
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] argrento commented on pull request #10867: Update gradle version and other changes in android apps
Posted by GitBox <gi...@apache.org>.
argrento commented on PR #10867:
URL: https://github.com/apache/tvm/pull/10867#issuecomment-1120456187
New PR because I messed a little bit :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org