You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "jbertram (via GitHub)" <gi...@apache.org> on 2023/06/19 18:47:05 UTC
[GitHub] [activemq-artemis] jbertram opened a new pull request, #4515: ARTEMIS-4311 fix typo
jbertram opened a new pull request, #4515:
URL: https://github.com/apache/activemq-artemis/pull/4515
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on a diff in pull request #4515: ARTEMIS-4311 fix typo
Posted by "gemmellr (via GitHub)" <gi...@apache.org>.
gemmellr commented on code in PR #4515:
URL: https://github.com/apache/activemq-artemis/pull/4515#discussion_r1235209364
##########
docs/user-manual/en/message-grouping.md:
##########
@@ -89,7 +89,7 @@ However if you really do want to close a group you can add a negative sequence n
Example:
```java
-Mesasge message = session.createTextMessage("<foo>hey</foo>");
+message message = session.createTextMessage("<foo>hey</foo>");
Review Comment:
Should be upper case M to match the interface type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr merged pull request #4515: ARTEMIS-4311 fix typo
Posted by "gemmellr (via GitHub)" <gi...@apache.org>.
gemmellr merged PR #4515:
URL: https://github.com/apache/activemq-artemis/pull/4515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on a diff in pull request #4515: ARTEMIS-4311 fix typo
Posted by "brusdev (via GitHub)" <gi...@apache.org>.
brusdev commented on code in PR #4515:
URL: https://github.com/apache/activemq-artemis/pull/4515#discussion_r1234734514
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPLargeMessage.java:
##########
@@ -398,7 +398,7 @@ private void genericParseLargeMessage() {
parsingBuffer = null;
} catch (RuntimeException expected) {
// this would mean the buffer is not complete yet, so we keep parsing it, until we can get enough bytes
- logger.debug("The buffer for AMQP Large Mesasge was probably not complete, so an exception eventually would be expected", expected);
+ logger.debug("The buffer for AMQP Large message was probably not complete, so an exception eventually would be expected", expected);
Review Comment:
do you change `Mesasge` to lowercase on purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org