You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Koji Noguchi (JIRA)" <ji...@apache.org> on 2009/04/21 20:30:47 UTC
[jira] Created: (HADOOP-5714) Metric to show number of fs.exists
(or number of getFileInfo) calls
Metric to show number of fs.exists (or number of getFileInfo) calls
-------------------------------------------------------------------
Key: HADOOP-5714
URL: https://issues.apache.org/jira/browse/HADOOP-5714
Project: Hadoop Core
Issue Type: New Feature
Components: dfs, metrics
Reporter: Koji Noguchi
Priority: Minor
In HADOOP-5712, it would have helped our debugging if I had this metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5714) Metric to show number of fs.exists
(or number of getFileInfo) calls
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-5714:
--------------------------------
Status: Patch Available (was: Open)
submitting patch
> Metric to show number of fs.exists (or number of getFileInfo) calls
> -------------------------------------------------------------------
>
> Key: HADOOP-5714
> URL: https://issues.apache.org/jira/browse/HADOOP-5714
> Project: Hadoop Core
> Issue Type: New Feature
> Components: dfs, metrics
> Reporter: Koji Noguchi
> Assignee: Jakob Homan
> Priority: Minor
> Attachments: HADOOP-5714.patch
>
>
> In HADOOP-5712, it would have helped our debugging if I had this metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5714) Metric to show number of fs.exists
(or number of getFileInfo) calls
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated HADOOP-5714:
--------------------------------
Attachment: HADOOP-5714.patch
Implemented Koji's request. New numFileInfoOps metric. Unit tests are fine.
{code}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
{code}
No tests as minor change. Manually tested.
> Metric to show number of fs.exists (or number of getFileInfo) calls
> -------------------------------------------------------------------
>
> Key: HADOOP-5714
> URL: https://issues.apache.org/jira/browse/HADOOP-5714
> Project: Hadoop Core
> Issue Type: New Feature
> Components: dfs, metrics
> Reporter: Koji Noguchi
> Assignee: Jakob Homan
> Priority: Minor
> Attachments: HADOOP-5714.patch
>
>
> In HADOOP-5712, it would have helped our debugging if I had this metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5714) Metric to show number of fs.exists
(or number of getFileInfo) calls
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706542#action_12706542 ]
Jakob Homan commented on HADOOP-5714:
-------------------------------------
failure is {{org.apache.hadoop.mapred.TestCapacitySchedulerConf}}, which is currently known bad. Lack of tests mentioned above.
> Metric to show number of fs.exists (or number of getFileInfo) calls
> -------------------------------------------------------------------
>
> Key: HADOOP-5714
> URL: https://issues.apache.org/jira/browse/HADOOP-5714
> Project: Hadoop Core
> Issue Type: New Feature
> Components: dfs, metrics
> Reporter: Koji Noguchi
> Assignee: Jakob Homan
> Priority: Minor
> Attachments: HADOOP-5714.patch
>
>
> In HADOOP-5712, it would have helped our debugging if I had this metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5714) Metric to show number of fs.exists
(or number of getFileInfo) calls
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706348#action_12706348 ]
Hadoop QA commented on HADOOP-5714:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12407186/HADOOP-5714.patch
against trunk revision 771661.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/293/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/293/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/293/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/293/console
This message is automatically generated.
> Metric to show number of fs.exists (or number of getFileInfo) calls
> -------------------------------------------------------------------
>
> Key: HADOOP-5714
> URL: https://issues.apache.org/jira/browse/HADOOP-5714
> Project: Hadoop Core
> Issue Type: New Feature
> Components: dfs, metrics
> Reporter: Koji Noguchi
> Assignee: Jakob Homan
> Priority: Minor
> Attachments: HADOOP-5714.patch
>
>
> In HADOOP-5712, it would have helped our debugging if I had this metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-5714) Metric to show number of fs.exists
(or number of getFileInfo) calls
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan reassigned HADOOP-5714:
-----------------------------------
Assignee: Jakob Homan
> Metric to show number of fs.exists (or number of getFileInfo) calls
> -------------------------------------------------------------------
>
> Key: HADOOP-5714
> URL: https://issues.apache.org/jira/browse/HADOOP-5714
> Project: Hadoop Core
> Issue Type: New Feature
> Components: dfs, metrics
> Reporter: Koji Noguchi
> Assignee: Jakob Homan
> Priority: Minor
>
> In HADOOP-5712, it would have helped our debugging if I had this metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5714) Metric to show number of fs.exists
(or number of getFileInfo) calls
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5714:
-------------------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
0.20.1
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
+1 patch looks good.
I just have committed this to 0.20.1 and above. Thanks, Jakob!
> Metric to show number of fs.exists (or number of getFileInfo) calls
> -------------------------------------------------------------------
>
> Key: HADOOP-5714
> URL: https://issues.apache.org/jira/browse/HADOOP-5714
> Project: Hadoop Core
> Issue Type: New Feature
> Components: dfs, metrics
> Reporter: Koji Noguchi
> Assignee: Jakob Homan
> Priority: Minor
> Fix For: 0.20.1, 0.21.0
>
> Attachments: HADOOP-5714.patch
>
>
> In HADOOP-5712, it would have helped our debugging if I had this metric.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.