You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "e11it (via GitHub)" <gi...@apache.org> on 2023/08/31 14:15:45 UTC

[GitHub] [impala] e11it opened a new pull request, #59: Fix ImpalaToPrometheusName: replace single quote to underscore

e11it opened a new pull request, #59:
URL: https://github.com/apache/impala/pull/59

   Some metrics name in Java 11 contains single quote(example: `CodeHeap 'profiled methods'`). 
   Single quote not allowed for prometheus metrics.
   
   This fix resolve this issue by replace single quote with underscore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@impala.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix ImpalaToPrometheusName: replace single quote to underscore [impala]

Posted by "MikaelSmith (via GitHub)" <gi...@apache.org>.
MikaelSmith closed pull request #59: Fix ImpalaToPrometheusName: replace single quote to underscore
URL: https://github.com/apache/impala/pull/59


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@impala.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [impala] bartash commented on pull request #59: Fix ImpalaToPrometheusName: replace single quote to underscore

Posted by "bartash (via GitHub)" <gi...@apache.org>.
bartash commented on PR #59:
URL: https://github.com/apache/impala/pull/59#issuecomment-1707028276

   Thanks for your contribution! We don't use pull requests in Apache Impala, we use Gerrit instead: https://gerrit.cloudera.org/.
   
   https://cwiki.apache.org/confluence/display/IMPALA/Using+Gerrit+to+submit+and+review+patches has a walkthrough for uploading patches for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@impala.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org