You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/08 04:53:11 UTC
[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1867: chore: refactored test create-route-with-proxy-rewrite-plugin.spec.js
iamayushdas opened a new pull request #1867:
URL: https://github.com/apache/apisix-dashboard/pull/1867
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- [x] Refactor
**What changes will this PR take into?**
Refactor Testcase for Frontend.
**Related issues**
related issue #1774
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [x] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1867: chore: refactored test create-route-with-proxy-rewrite-plugin.spec.js
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1867:
URL: https://github.com/apache/apisix-dashboard/pull/1867#issuecomment-835106696
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1867?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1867](https://codecov.io/gh/apache/apisix-dashboard/pull/1867?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (480befd) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/b1e66a286a7fa0fd276bcd4bf1dee8a065947676?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1e66a2) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 480befd differs from pull request most recent head edeb2d6. Consider uploading reports for the commit edeb2d6 to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1867 +/- ##
==========================================
+ Coverage 72.10% 72.17% +0.06%
==========================================
Files 125 125
Lines 2947 2947
Branches 711 711
==========================================
+ Hits 2125 2127 +2
+ Misses 822 820 -2
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `72.17% <ø> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1867/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1867?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1867?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1e66a2...edeb2d6](https://codecov.io/gh/apache/apisix-dashboard/pull/1867?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1867: chore: refactored test create-route-with-proxy-rewrite-plugin.spec.js
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1867:
URL: https://github.com/apache/apisix-dashboard/pull/1867#issuecomment-835094816
Deploy preview for *apisix-dashboard* processing.
Building with commit edeb2d643af6999cc322d85e01436c4532ce3d27
https://app.netlify.com/sites/apisix-dashboard/deploys/6096192e6d5d8300070fa45d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1867: chore: refactored test create-route-with-proxy-rewrite-plugin.spec.js
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1867:
URL: https://github.com/apache/apisix-dashboard/pull/1867#issuecomment-835094816
Deploy preview for *apisix-dashboard* ready!
Built with commit edeb2d643af6999cc322d85e01436c4532ce3d27
https://deploy-preview-1867--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran merged pull request #1867: chore: refactored test create-route-with-proxy-rewrite-plugin.spec.js
Posted by GitBox <gi...@apache.org>.
liuxiran merged pull request #1867:
URL: https://github.com/apache/apisix-dashboard/pull/1867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org