You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@stanbol.apache.org by rh...@apache.org on 2018/12/01 20:44:15 UTC
svn commit: r1847921 - in /stanbol/trunk:
commons/solr/managed/src/main/java/org/apache/stanbol/commons/solr/managed/
commons/testing/jarexec/src/main/java/org/apache/stanbol/commons/testing/jarexec/
enhancement-engines/entitylinking/labeltokenizer-luc...
Author: rharo
Date: Sat Dec 1 20:44:15 2018
New Revision: 1847921
URL: http://svn.apache.org/viewvc?rev=1847921&view=rev
Log:
Merged PRs for STANBOL-1473 to STANBOL-1476. Kudos to Furkan Karmaci
Modified:
stanbol/trunk/commons/solr/managed/src/main/java/org/apache/stanbol/commons/solr/managed/IndexMetadata.java
stanbol/trunk/commons/testing/jarexec/src/main/java/org/apache/stanbol/commons/testing/jarexec/JarExecutor.java
stanbol/trunk/enhancement-engines/entitylinking/labeltokenizer-lucene/src/main/java/org/apache/stanbol/enhancer/engines/entitylinking/labeltokenizer/lucene/LuceneLabelTokenizer.java
Modified: stanbol/trunk/commons/solr/managed/src/main/java/org/apache/stanbol/commons/solr/managed/IndexMetadata.java
URL: http://svn.apache.org/viewvc/stanbol/trunk/commons/solr/managed/src/main/java/org/apache/stanbol/commons/solr/managed/IndexMetadata.java?rev=1847921&r1=1847920&r2=1847921&view=diff
==============================================================================
--- stanbol/trunk/commons/solr/managed/src/main/java/org/apache/stanbol/commons/solr/managed/IndexMetadata.java (original)
+++ stanbol/trunk/commons/solr/managed/src/main/java/org/apache/stanbol/commons/solr/managed/IndexMetadata.java Sat Dec 1 20:44:15 2018
@@ -161,7 +161,7 @@ public final class IndexMetadata extends
StringBuilder value = new StringBuilder();
boolean first = true;
for(String archive:archives){
- if(archive != null && archive != null){
+ if(archive != null){
if(!first){
value.append(',');
} else {
@@ -174,7 +174,7 @@ public final class IndexMetadata extends
}
public boolean isSynchronized(){
String value = getProperty(SYNCHRONIZED);
- return value == null ? false : Boolean.parseBoolean(value);
+ return Boolean.parseBoolean(value);
}
public void setSynchronized(boolean state){
setProperty(SYNCHRONIZED, Boolean.toString(state));
Modified: stanbol/trunk/commons/testing/jarexec/src/main/java/org/apache/stanbol/commons/testing/jarexec/JarExecutor.java
URL: http://svn.apache.org/viewvc/stanbol/trunk/commons/testing/jarexec/src/main/java/org/apache/stanbol/commons/testing/jarexec/JarExecutor.java?rev=1847921&r1=1847920&r2=1847921&view=diff
==============================================================================
--- stanbol/trunk/commons/testing/jarexec/src/main/java/org/apache/stanbol/commons/testing/jarexec/JarExecutor.java (original)
+++ stanbol/trunk/commons/testing/jarexec/src/main/java/org/apache/stanbol/commons/testing/jarexec/JarExecutor.java Sat Dec 1 20:44:15 2018
@@ -72,13 +72,9 @@ public final class JarExecutor {
return serverPort;
}
- public static JarExecutor getInstance(Properties config) throws ExecutorException {
+ public synchronized static JarExecutor getInstance(Properties config) throws ExecutorException {
if (instance == null) {
- synchronized (JarExecutor.class) {
- if (instance == null) {
- instance = new JarExecutor(config);
- }
- }
+ instance = new JarExecutor(config);
}
return instance;
}
Modified: stanbol/trunk/enhancement-engines/entitylinking/labeltokenizer-lucene/src/main/java/org/apache/stanbol/enhancer/engines/entitylinking/labeltokenizer/lucene/LuceneLabelTokenizer.java
URL: http://svn.apache.org/viewvc/stanbol/trunk/enhancement-engines/entitylinking/labeltokenizer-lucene/src/main/java/org/apache/stanbol/enhancer/engines/entitylinking/labeltokenizer/lucene/LuceneLabelTokenizer.java?rev=1847921&r1=1847920&r2=1847921&view=diff
==============================================================================
--- stanbol/trunk/enhancement-engines/entitylinking/labeltokenizer-lucene/src/main/java/org/apache/stanbol/enhancer/engines/entitylinking/labeltokenizer/lucene/LuceneLabelTokenizer.java (original)
+++ stanbol/trunk/enhancement-engines/entitylinking/labeltokenizer-lucene/src/main/java/org/apache/stanbol/enhancer/engines/entitylinking/labeltokenizer/lucene/LuceneLabelTokenizer.java Sat Dec 1 20:44:15 2018
@@ -206,10 +206,19 @@ public class LuceneLabelTokenizer implem
tokens.add(label.substring(offset.startOffset(), offset.endOffset()));
}
tokenizer.end();
- tokenizer.close();
} catch (IOException e) {
log.error("IOException while reading from a StringReader :(",e);
return null;
+ } finally {
+ try {
+ if (tokenizer == null) {
+ return null;
+ }
+ tokenizer.close();
+ } catch (IOException e) {
+ log.error("IOException while closing a StringReader :(",e);
+ return null;
+ }
}
return tokens.toArray(new String[tokens.size()]);
} else {